Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to deploy different software package to a subset of nodes #232

Merged
merged 46 commits into from
May 16, 2024

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Apr 16, 2024

Description

This pull request changes the following:

  • Update work flow to setup java and gradle if end to end test enabled
  • Update work flow to clone hedera repo on runner and build the code
  • Update node.mjs to copy data/lib and data/apps to pods if flag localBuildPath is valid
  • Upload PlatformTestingApp test app/jars and test josn if --app and --appConfig is defined
  • Update node.mjs to scan swirlds.log instead of hgcaa.log for PlatformTestingApp
  • New end to end test to make sure Hedera App and PTT both working
  • Update README template

Related Issues

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…local-build

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from a team and leninmehedy as code owners April 16, 2024 00:38
Copy link

codacy-production bot commented Apr 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 29fe5ee1 95.45%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (29fe5ee) Report Missing Report Missing Report Missing
Head commit (f353f32) 3187 2593 81.36%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#232) 22 21 95.45%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.01%. Comparing base (f022b08) to head (7963fdf).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   81.80%   82.01%   +0.20%     
==========================================
  Files          34       34              
  Lines        3936     3987      +51     
  Branches      694      709      +15     
==========================================
+ Hits         3220     3270      +50     
- Misses        716      717       +1     
Files Coverage Δ
src/commands/flags.mjs 94.73% <100.00%> (+0.29%) ⬆️
src/core/platform_installer.mjs 89.57% <100.00%> (-0.07%) ⬇️
version.mjs 100.00% <100.00%> (ø)
src/commands/node.mjs 80.44% <94.82%> (+0.98%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Unit Test Results - Linux

  1 files   18 suites   1m 12s ⏱️
118 tests 118 ✅ 0 💤 0 ❌
143 runs  143 ✅ 0 💤 0 ❌

Results for commit 7963fdf.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Unit Test Results - Windows

  1 files   18 suites   1m 47s ⏱️
118 tests 118 ✅ 0 💤 0 ❌
143 runs  143 ✅ 0 💤 0 ❌

Results for commit 7963fdf.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

E2E Test Results

  1 files  ±0   14 suites  +2   33m 9s ⏱️ + 7m 17s
111 tests +8  110 ✅ +12  0 💤 ±0  1 ❌  - 4 
117 runs  +8  116 ✅ +14  0 💤 ±0  1 ❌  - 6 

For more details on these failures, see this check.

Results for commit cec2404. ± Comparison against base commit a08c52f.

♻️ This comment has been updated with latest results.

@JeffreyDallas JeffreyDallas changed the title 00207 d local build feat: new flag to use local hedera build Apr 16, 2024
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
jeromy-cannon
jeromy-cannon previously approved these changes Apr 18, 2024
src/commands/node.mjs Outdated Show resolved Hide resolved
src/commands/node.mjs Outdated Show resolved Hide resolved
src/commands/node.mjs Outdated Show resolved Hide resolved
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
JeffreyDallas and others added 6 commits April 19, 2024 12:43
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

github-actions bot commented May 14, 2024

Test Results

8 tests   8 ✅  3m 0s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit c1ffe4b.

♻️ This comment has been updated with latest results.

JeffreyDallas and others added 3 commits May 15, 2024 09:33
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
jeromy-cannon
jeromy-cannon previously approved these changes May 16, 2024
@jeromy-cannon jeromy-cannon dismissed leninmehedy’s stale review May 16, 2024 09:17

Jeffrey finished Lenin's requested changes

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
jeromy-cannon
jeromy-cannon previously approved these changes May 16, 2024
Copy link
Contributor

github-actions bot commented May 16, 2024

E2E Node Local Build Tests Coverage Report

8 tests   8 ✅  2m 56s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit 7963fdf.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 8d7b00f1 40.38%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8d7b00f) Report Missing Report Missing Report Missing
Head commit (7963fdf) 3370 2742 81.36%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#232) 52 21 40.38%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jeromy-cannon jeromy-cannon merged commit 5e95030 into main May 16, 2024
31 checks passed
@jeromy-cannon jeromy-cannon deleted the 00207-D-local-build branch May 16, 2024 10:16
swirlds-automation added a commit that referenced this pull request May 16, 2024
## [0.25.0](v0.24.0...v0.25.0) (2024-05-16)

### Features

* ability to deploy different software package to a subset of nodes ([#232](#232)) ([5e95030](5e95030))
* add `solo node add` subcommand ([#234](#234)) ([8cc3802](8cc3802))

### Bug Fixes

* enhance profile manager to take mirror node component overrides to increase pipeline stability ([#289](#289)) ([c89a042](c89a042))
* increase wait time for when recycling an haproxy pod for a node ([#292](#292)) ([cb5a1c6](cb5a1c6))
* jsdoc could not recognizing Promise<[*]> ([#275](#275)) ([9a9c00c](9a9c00c))
* revert to sleep and remove jest.runAllTicks from e2e test ([#255](#255)) ([a7cf6bf](a7cf6bf))
* use latest FST chart and a single consensus node during mirror-node e2e test ([#264](#264)) ([5a5a02f](5a5a02f))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants