fix: added missing async/await where needed #551

jeromy-cannon · 2024-09-06T11:25:30Z

Description

This pull request changes the following:

Fix test cases hanging due to missing await keywords, this could have been causing a lot of our pipeline issues
during solo node update check for pod to be condition ready to make sure that sidecars are up
fix random test sequence to give the same sequence consistently provided the same seed is used
make sure that the node client is closed first in refreshNodeClient
change the remaining two references of 'sh' to 'bash'
fixed some issues causing random test failures

Related Issues

Closes Fix test cases hanging due to missing await keywords #550

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

github-actions · 2024-09-06T11:28:00Z

Unit Test Results - Linux

1 files 19 suites 48s ⏱️
123 tests 123 ✅ 0 💤 0 ❌
149 runs 149 ✅ 0 💤 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-06T11:29:29Z

Unit Test Results - Windows

1 files 19 suites 1m 38s ⏱️
123 tests 123 ✅ 0 💤 0 ❌
149 runs 149 ✅ 0 💤 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-06T11:30:50Z

E2E Node PEM Stop Tests Coverage Report

13 tests 13 ✅ 2m 37s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-06T11:30:55Z

E2E Relay Tests Coverage Report

1 files 1 suites 2m 42s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs 7 ✅ 0 💤 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-06T11:31:12Z

E2E Tests Coverage Report

58 tests 58 ✅ 4m 32s ⏱️
9 suites 0 💤
1 files 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-06T11:31:18Z

E2E Node PFX Kill Tests Coverage Report

13 tests 13 ✅ 3m 6s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-06T11:32:03Z

E2E Mirror Node Tests Coverage Report

1 files 1 suites 3m 43s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
14 runs 14 ✅ 0 💤 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-06T11:32:22Z

E2E Node Local Build Tests Coverage Report

10 tests 10 ✅ 2m 57s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-06T11:33:51Z

E2E Node Delete Tests Coverage Report

10 tests 10 ✅ 5m 38s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-06T11:41:28Z

E2E Node Update Tests Coverage Report

12 tests 12 ✅ 5m 31s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-06T11:43:31Z

E2E Node Add Tests Coverage Report

22 tests 22 ✅ 13m 58s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit 2e92e75.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

codacy-production · 2024-09-06T13:36:22Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `f639a3b`¹	✅ 82.50%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`f639a3b`)	Report Missing	Report Missing	Report Missing
Head commit (`2e92e75`)	4150	3284	79.13%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#551)	40	33	82.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-09-06T13:36:37Z

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.59%. Comparing base (c81c76a) to head (2e92e75).
Report is 20 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/node.mjs	96.15%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   81.66%   83.59%   +1.92%     
==========================================
  Files          35       36       +1     
  Lines        4429     4950     +521     
  Branches      671      700      +29     
==========================================
+ Hits         3617     4138     +521     
  Misses        812      812

Files with missing lines	Coverage Δ
src/commands/mirror_node.mjs	`74.26% <100.00%> (ø)`
src/commands/network.mjs	`62.18% <100.00%> (+6.63%)`	⬆️
src/core/account_manager.mjs	`80.73% <100.00%> (+0.23%)`	⬆️
src/core/k8.mjs	`88.47% <ø> (+1.99%)`	⬆️
src/core/key_manager.mjs	`89.85% <100.00%> (-0.20%)`	⬇️
src/core/platform_installer.mjs	`88.05% <100.00%> (+1.61%)`	⬆️
src/commands/node.mjs	`85.02% <96.15%> (+6.27%)`	⬆️

... and 3 files with indirect coverage changes

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

… the same seed Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

## [0.29.0](v0.28.1...v0.29.0) (2024-09-06) ### Features * add local build support for node add command ([#509](#509)) ([a7e778f](a7e778f)) * add node delete and update command ([#500](#500)) ([9f8549a](9f8549a)) * use k8s secrets to store node gossip and grpc tls keys and mount them ([#499](#499)) ([ede1842](ede1842)) ### Bug Fixes * added missing async/await where needed ([#551](#551)) ([d8e5032](d8e5032)) * improve types in JSDoc and fix typo in '/src/commands/account.mjs' ([#507](#507)) ([74c9e2c](74c9e2c)) * need to update agreement key together with signing key ([#539](#539)) ([f9b2e21](f9b2e21)) * removed the custom ip address logic and '@hashgraph/proto' ([#518](#518)) ([c81c76a](c81c76a))

swirlds-automation · 2024-09-06T19:02:23Z

🎉 This PR is included in version 0.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

added missing async/await where needed

3a77aa1

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

jeromy-cannon self-assigned this Sep 6, 2024

jeromy-cannon added 2 commits September 6, 2024 14:16

update to use bash instead of sh

e5b65e1

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

in node update wait for pod to be condition=ready before continuing

76df3bf

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

jeromy-cannon added 6 commits September 6, 2024 14:52

update expect messages in jest test cases

e17de7d

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

make sure to close the accountManager before doing a refreshNodeClient

406e629

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

fixed random test order to consistently generate the same order given…

8cea008

… the same seed Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

fix fallout from when I removed generate keys from node setup

3543d0e

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

accidentally left this commented out

41dbde7

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

rebase issue fixed

2e92e75

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

jeromy-cannon marked this pull request as ready for review September 6, 2024 16:45

jeromy-cannon requested review from leninmehedy and a team as code owners September 6, 2024 16:45

jeromy-cannon requested review from nathanklick, JeffreyDallas, Ivo-Yankov and instamenta September 6, 2024 16:45

JeffreyDallas approved these changes Sep 6, 2024

View reviewed changes

jeromy-cannon merged commit d8e5032 into main Sep 6, 2024
39 checks passed

jeromy-cannon deleted the 00550-missing-await-keywords branch September 6, 2024 18:32

swirlds-automation added the released label Sep 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: added missing async/await where needed #551

fix: added missing async/await where needed #551

jeromy-cannon commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

codacy-production bot commented Sep 6, 2024 •

edited

Loading

codecov bot commented Sep 6, 2024 •

edited

Loading

swirlds-automation commented Sep 6, 2024

fix: added missing async/await where needed #551

fix: added missing async/await where needed #551

Conversation

jeromy-cannon commented Sep 6, 2024 • edited Loading

Description

Related Issues

github-actions bot commented Sep 6, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Sep 6, 2024 • edited Loading

Unit Test Results - Windows

github-actions bot commented Sep 6, 2024 • edited Loading

E2E Node PEM Stop Tests Coverage Report

github-actions bot commented Sep 6, 2024 • edited Loading

E2E Relay Tests Coverage Report

github-actions bot commented Sep 6, 2024 • edited Loading

E2E Tests Coverage Report

github-actions bot commented Sep 6, 2024 • edited Loading

E2E Node PFX Kill Tests Coverage Report

github-actions bot commented Sep 6, 2024 • edited Loading

E2E Mirror Node Tests Coverage Report

github-actions bot commented Sep 6, 2024 • edited Loading

E2E Node Local Build Tests Coverage Report

github-actions bot commented Sep 6, 2024 • edited Loading

E2E Node Delete Tests Coverage Report

github-actions bot commented Sep 6, 2024 • edited Loading

E2E Node Update Tests Coverage Report

github-actions bot commented Sep 6, 2024 • edited Loading

E2E Node Add Tests Coverage Report

codacy-production bot commented Sep 6, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Sep 6, 2024 • edited Loading

Codecov Report

swirlds-automation commented Sep 6, 2024

jeromy-cannon commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

codacy-production bot commented Sep 6, 2024 •

edited

Loading

codecov bot commented Sep 6, 2024 •

edited

Loading