Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to user-agent request header with env var data #47

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Aug 14, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: hashicorp/terraform-provider-aws#9149

Please briefly describe the changes proposed in this pull request.

  • In addition to the user-agent info stored in the Config object, we also want enable appending custom agent information set via an environment variable, namely, TF_APPEND_USER_AGENT.

@anGie44 anGie44 requested a review from a team as a code owner August 14, 2020 20:43
@hashicorp-cla
Copy link

hashicorp-cla commented Aug 14, 2020

CLA assistant check
All committers have signed the CLA.

@anGie44
Copy link
Contributor Author

anGie44 commented Aug 14, 2020

is there any session unit testing that can be done to validate the request header?

@bflad bflad added the enhancement New feature or request label Aug 18, 2020
@bflad bflad added this to the v0.6.0 milestone Aug 18, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 Regarding the unit testing, let's create a separate tracking issue since its very low risk to release and manually verify downstream (if it cannot be manually verified here). It may be possible by inspecting sess.Handlers similar to how the AWS Go SDK does unit testing in its repository.

@anGie44 anGie44 merged commit ce5e27f into hashicorp:master Aug 18, 2020
@anGie44 anGie44 deleted the f-custom-user-agent-info branch August 18, 2020 14:42
anGie44 added a commit that referenced this pull request Aug 18, 2020
anGie44 added a commit that referenced this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants