Allow education to merge image PRs and web presence to control the website source #5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
previously approved these changes
Dec 6, 2024
|
@johanbrandhorst Sorry, that definitely wasn't the intention, good catch! I think this recent change keeps the Boundary team's global permissions. My hope is to let web approve website PRs and the education team approve docs PRs. We don't need to require their approvals specifically. |
johanbrandhorst
previously approved these changes
Dec 7, 2024
|
sorry for the back and forth. This last change lets us edit the docs side navigation as well |
moduli
approved these changes
Dec 10, 2024
louisruch
approved these changes
Dec 11, 2024
ddebko
approved these changes
Dec 11, 2024
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding education and web presence to the code owners file for pieces of the repo that they will need to merge PRs to.