From 88a7bf9942d285dab3402e6330504a6c9d5d51ac Mon Sep 17 00:00:00 2001 From: Michael Zalimeni Date: Mon, 24 Jul 2023 16:50:05 -0400 Subject: [PATCH] Pin Go 1.20.5 in integration-tests Avoid testcontainers breakage due to validation added in Go 1.20.6 until that issue is resolved. Keep the global version bump to 1.20.6 to resolve CVEs. --- .github/workflows/consul-dataplane-checks.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/consul-dataplane-checks.yaml b/.github/workflows/consul-dataplane-checks.yaml index 611e4589..087a2b98 100644 --- a/.github/workflows/consul-dataplane-checks.yaml +++ b/.github/workflows/consul-dataplane-checks.yaml @@ -42,7 +42,12 @@ jobs: - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3 - uses: actions/setup-go@fac708d6674e30b6ba41289acaab6d4b75aa0753 # v4.0.1 with: - go-version: ${{ needs.get-go-version.outputs.go-version }} + # pinning this to 1.20.5 because this issue in go-testcontainers occurs + # in 1.20.6 with the error "http: invalid Host header, host port waiting failed" + # https://github.com/testcontainers/testcontainers-go/issues/1359 + # remove setting this when the above issue is fixed so that the job will + # just get the go version from .go-version. + go-version: 1.20.5 - run: make docker # Currently the server version below is set to 1.15-dev: integration-tests/main_test.go - run: echo "VERSION=$(make version)" >> $GITHUB_ENV