Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-write lifecycle-sidecar to be more efficient #275

Closed
lkysow opened this issue Jun 12, 2020 · 1 comment
Closed

Re-write lifecycle-sidecar to be more efficient #275

lkysow opened this issue Jun 12, 2020 · 1 comment
Labels
area/connect Related to Connect service mesh, e.g. injection type/enhancement New feature or request

Comments

@lkysow
Copy link
Member

lkysow commented Jun 12, 2020

The consul-k8s lifecycle-sidecar command ensures that a service is always registered with the local consul client. It runs as a sidecar and is used by connect services (it gets injected) and by gateways (part of their helm config).

It works by running consul services register every 10s by default. This is a naive solution. It would be better for it to only re-register the service when it gets deregistered from Consul.
@lkysow lkysow added area/connect Related to Connect service mesh, e.g. injection type/enhancement New feature or request labels Jun 12, 2020
@hamishforbes hamishforbes mentioned this issue Aug 19, 2020
Closed
@DerekStrickland DerekStrickland linked a pull request Sep 11, 2020 that will close this issue
Refactor lifecycle-sidecar to check and set instead of constantly rew… #324
Closed
2 tasks
@lkysow
Copy link
Member Author

lkysow commented Apr 8, 2021

Closed by #457 that removes need for lifecycle sidecar re-registration. Will be in next release.

@lkysow lkysow closed this as completed Apr 8, 2021
ndhanushkodi pushed a commit to ndhanushkodi/consul-k8s that referenced this issue Jul 9, 2021
@lkysow
Merge pull request hashicorp#275 from hashicorp/release-0.11.1
5592e66 
Upgrade to consul-k8s 0.9.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/connect Related to Connect service mesh, e.g. injection type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor lifecycle-sidecar to check and set instead of constantly rew… hashicorp/consul-k8s
1 participant
@lkysow