Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add peerName to ExportedServices. #1239

Merged
merged 1 commit into from
May 26, 2022
Merged

Add peerName to ExportedServices. #1239

merged 1 commit into from
May 26, 2022

Conversation

thisisnotashwin
Copy link
Contributor

Changes proposed in this PR:

  • add peerName to ExportedServices CRD
  • add validations to ensure both peername and partition cannot be specified but at least one of them needs to be specified.

How I've tested this PR:

  • unit tests
  • deploying locally on kubernetes
    How I expect reviewers to test this PR:
  • 👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@thisisnotashwin thisisnotashwin requested review from ndhanushkodi, a team and curtbushko and removed request for a team May 25, 2022 16:34
@thisisnotashwin thisisnotashwin force-pushed the ashwin/update-exported-services-with-peer-names branch from 976361b to a0aa8fc Compare May 25, 2022 17:20
@thisisnotashwin thisisnotashwin changed the base branch from main to peering May 25, 2022 20:01
ndhanushkodi
ndhanushkodi approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks peer-fect!

curtbushko
curtbushko approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thisisnotashwin thisisnotashwin merged commit 8465478 into peering May 26, 2022
@thisisnotashwin thisisnotashwin deleted the ashwin/update-exported-services-with-peer-names branch May 26, 2022 15:46
ndhanushkodi pushed a commit that referenced this pull request Jun 13, 2022
@ndhanushkodi
Add peerName to ExportedServices. (#1239)
8c6ceb7
ndhanushkodi pushed a commit that referenced this pull request Jun 13, 2022
@ndhanushkodi
Add peerName to ExportedServices. (#1239)
d4ad150
ndhanushkodi pushed a commit that referenced this pull request Jun 15, 2022
@ndhanushkodi
Add peerName to ExportedServices. (#1239)
48d71c2
thisisnotashwin pushed a commit that referenced this pull request Jun 16, 2022
@thisisnotashwin
Add peerName to ExportedServices. (#1239)
2c6eb17
thisisnotashwin pushed a commit that referenced this pull request Jun 16, 2022
@thisisnotashwin
Add peerName to ExportedServices. (#1239)
983b2d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

@curtbushko curtbushko curtbushko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisisnotashwin @curtbushko @ndhanushkodi