Backfill unit tests for peering dialler #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
ndhanushkodi,
a team and
kschoche
and removed request for
a team
kschoche
reviewed
Jun 9, 2022
kschoche
reviewed
Jun 9, 2022
kschoche
reviewed
Jun 9, 2022
kschoche
reviewed
Jun 9, 2022
ndhanushkodi
approved these changes
Jun 10, 2022
- Clean up some of the logic in peering dialler and acceptor - Rename handler -> connectWebhook
thisisnotashwin
force-pushed
the
backfill-unit-tests
branch
from
de51d6c to
a398350
Compare
kschoche
reviewed
Jun 10, 2022
| return []runtime.Object{dialer} | ||
| }, | ||
| expErr: "PeeringDialer spec.peer.secret was not set", | ||
| peeringSecret: func(_ string) *corev1.Secret { return nil }, |
kschoche
reviewed
Jun 10, 2022
kschoche
reviewed
Jun 10, 2022
kschoche
approved these changes
Jun 10, 2022
ndhanushkodi
pushed a commit
that referenced
this pull request
Jun 13, 2022
- Clean up some of the logic in peering dialler and acceptor - Rename handler -> connectWebhook
ndhanushkodi
pushed a commit
that referenced
this pull request
Jun 13, 2022
- Clean up some of the logic in peering dialler and acceptor - Rename handler -> connectWebhook
ndhanushkodi
pushed a commit
that referenced
this pull request
Jun 13, 2022
- Clean up some of the logic in peering dialler and acceptor - Rename handler -> connectWebhook
ndhanushkodi
pushed a commit
that referenced
this pull request
Jun 15, 2022
- Clean up some of the logic in peering dialler and acceptor - Rename handler -> connectWebhook
thisisnotashwin
pushed a commit
that referenced
this pull request
Jun 16, 2022
- Clean up some of the logic in peering dialler and acceptor - Rename handler -> connectWebhook
thisisnotashwin
pushed a commit
that referenced
this pull request
Jun 16, 2022
- Clean up some of the logic in peering dialler and acceptor - Rename handler -> connectWebhook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: