Pipeline Updates #1908
Merged
Pipeline Updates #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkermichael
force-pushed
the
mw/fix-pipeline-feb-2023
branch
7 times, most recently
from
ff635be to
d362d3f
Compare
wilkermichael
force-pushed
the
mw/fix-pipeline-feb-2023
branch
from
59fc483 to
b07cab0
Compare
wilkermichael
requested review from
a team,
thisisnotashwin and
malizz
and removed request for
a team
wilkermichael
commented
Feb 17, 2023
wilkermichael
commented
Feb 17, 2023
thisisnotashwin
approved these changes
Feb 17, 2023
wilkermichael
force-pushed
the
mw/fix-pipeline-feb-2023
branch
from
b07cab0 to
3d59e87
Compare
- ran go mod tidy on all go mod files
- removed compatibility tests, those won't be needed now that we have paired Consul/Consul-K8s versions
- updated tests to remove require.New(t) and instead pass t directly when required
wilkermichael
force-pushed
the
mw/fix-pipeline-feb-2023
branch
from
3d59e87 to
ac26dfa
Compare
wilkermichael
force-pushed
the
mw/fix-pipeline-feb-2023
branch
from
1c418a7 to
dd6f630
Compare
thisisnotashwin
approved these changes
Feb 17, 2023
1 task
This was referenced Feb 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you go through my PR commit by commit it's easier to review, I typically add extra context and you won't see things change between commits unintentionally
Changes proposed in this PR:
gotestsumcalls to usetestnamesthis improves debugging as you'll see which tests pass and fail, not just the package name with failing/passing tests1.1.xrelease branch for nightly testingHow I've tested this PR:
I verified that the nightly tests passed:
How I expect reviewers to test this PR:
👀
Checklist: