From dcd21af7c7a6e9e9beebf7d1aae71550d5bdffde Mon Sep 17 00:00:00 2001
From: John Cowen <jcowen@hashicorp.com>
Date: Thu, 24 Jan 2019 18:33:54 +0000
Subject: [PATCH] ui: Add initial blocking query acceptance tests

---
 .../tests/acceptance/dc/list-blocking.feature | 34 +++++++++++++++++
 .../steps/dc/list-blocking-steps.js           | 10 +++++
 ui-v2/tests/steps.js                          | 38 ++++++++++++++++++-
 3 files changed, 80 insertions(+), 2 deletions(-)
 create mode 100644 ui-v2/tests/acceptance/dc/list-blocking.feature
 create mode 100644 ui-v2/tests/acceptance/steps/dc/list-blocking-steps.js

diff --git a/ui-v2/tests/acceptance/dc/list-blocking.feature b/ui-v2/tests/acceptance/dc/list-blocking.feature
new file mode 100644
index 000000000000..790d20dce063
--- /dev/null
+++ b/ui-v2/tests/acceptance/dc/list-blocking.feature
@@ -0,0 +1,34 @@
+@setupApplicationTest
+Feature: dc / list-blocking
+  In order to see updates without refreshing the page
+  As a user
+  I want to see changes if I change consul externally
+  Background:
+    Given 1 datacenter model with the value "dc-1"
+    And settings from yaml
+    ---
+    consul:client:
+      blocking: 1
+      throttle: 200
+    ---
+  Scenario:
+    And 3 [Model] models
+    And a network latency of 100
+    When I visit the [Page] page for yaml
+    ---
+      dc: dc-1
+    ---
+    Then the url should be /dc-1/[Url]
+    And pause until I see 3 [Model] models
+    And an external edit results in 5 [Model] models
+    And pause until I see 5 [Model] models
+    And an external edit results in 1 [Model] model
+    And pause until I see 1 [Model] model
+    And an external edit results in 0 [Model] models
+    And pause until I see 0 [Model] models
+  Where:
+    --------------------------------------------
+    | Page       | Model       | Url           |
+    | services   | service     | services      |
+    | nodes      | node        | nodes         |
+    --------------------------------------------
diff --git a/ui-v2/tests/acceptance/steps/dc/list-blocking-steps.js b/ui-v2/tests/acceptance/steps/dc/list-blocking-steps.js
new file mode 100644
index 000000000000..3c9a76f69fa2
--- /dev/null
+++ b/ui-v2/tests/acceptance/steps/dc/list-blocking-steps.js
@@ -0,0 +1,10 @@
+import steps from '../steps';
+
+// step definitions that are shared between features should be moved to the
+// tests/acceptance/steps/steps.js file
+
+export default function(assert) {
+  return steps(assert).then('I should find a file', function() {
+    assert.ok(true, this.step);
+  });
+}
diff --git a/ui-v2/tests/steps.js b/ui-v2/tests/steps.js
index 859cfe830bee..d0adc96f5921 100644
--- a/ui-v2/tests/steps.js
+++ b/ui-v2/tests/steps.js
@@ -65,7 +65,10 @@ export default function(assert) {
       }, yadda)
     )
       // doubles
-      .given(['$number $model model[s]?', '$number $model models'], function(number, model) {
+      .given(['an external edit results in $number $model model[s]?'], function(number, model) {
+        return create(number, model);
+      })
+      .given(['$number $model model[s]?'], function(number, model) {
         return create(number, model);
       })
       .given(['$number $model model[s]? with the value "$value"'], function(number, model, value) {
@@ -77,7 +80,15 @@ export default function(assert) {
           return create(number, model, data);
         }
       )
-      .given(["I'm using a legacy token"], function(number, model, data) {
+      .given(['settings from yaml\n$yaml'], function(data) {
+        return Object.keys(data).forEach(function(key) {
+          window.localStorage[key] = JSON.stringify(data[key]);
+        });
+      })
+      .given('a network latency of $number', function(number) {
+        api.server.setCookie('CONSUL_LATENCY', number);
+      })
+      .given(["I'm using a legacy token"], function() {
         window.localStorage['consul:token'] = JSON.stringify({ AccessorID: null, SecretID: 'id' });
       })
       // TODO: Abstract this away from HTTP
@@ -188,6 +199,26 @@ export default function(assert) {
         });
       })
       // assertions
+      .then('pause until I see $number $model model[s]?', function(num, model) {
+        return new Promise(function(resolve) {
+          let count = 0;
+          const interval = setInterval(function() {
+            if (++count >= 50) {
+              clearInterval(interval);
+              assert.ok(false);
+              resolve();
+            }
+            const len = currentPage[`${pluralize(model)}`].filter(function(item) {
+              return item.isVisible;
+            }).length;
+            if (len === num) {
+              clearInterval(interval);
+              assert.equal(len, num, `Expected ${num} ${model}s, saw ${len}`);
+              resolve();
+            }
+          }, 100);
+        });
+      })
       .then('a $method request is made to "$url" with the body from yaml\n$yaml', function(
         method,
         url,
@@ -358,6 +389,9 @@ export default function(assert) {
       .then('I have settings like yaml\n$yaml', function(data) {
         // TODO: Inject this
         const settings = window.localStorage;
+        // TODO: this and the setup should probably use consul:
+        // as we are talking about 'settings' here not localStorage
+        // so the prefix should be hidden
         Object.keys(data).forEach(function(prop) {
           const actual = settings.getItem(prop);
           const expected = data[prop];