From dcfd03be00c86190c14d5a61b2275aba9e18b327 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?William=20Tisa=CC=88ter?= Date: Fri, 9 May 2014 11:38:29 +0200 Subject: [PATCH] Add TODOs for failing tests --- command/agent/catalog_endpoint_test.go | 1 + command/agent/health_endpoint_test.go | 7 +++++++ command/agent/rpc_client_test.go | 1 + command/agent/ui_endpoint_test.go | 2 ++ consul/catalog_endpoint_test.go | 1 + 5 files changed, 12 insertions(+) diff --git a/command/agent/catalog_endpoint_test.go b/command/agent/catalog_endpoint_test.go index d9454ab7ed87..f8b2b6a2c701 100644 --- a/command/agent/catalog_endpoint_test.go +++ b/command/agent/catalog_endpoint_test.go @@ -175,6 +175,7 @@ func TestCatalogNodes_Blocking(t *testing.T) { // Should block for a while if time.Now().Sub(start) < 50 * time.Millisecond { + // TODO: Failing t.Fatalf("too fast") } diff --git a/command/agent/health_endpoint_test.go b/command/agent/health_endpoint_test.go index 910d37df8b10..a4b4b9817e09 100644 --- a/command/agent/health_endpoint_test.go +++ b/command/agent/health_endpoint_test.go @@ -28,6 +28,8 @@ func TestHealthChecksInState(t *testing.T) { if err != nil { t.Fatalf("err: %v", err) } + + // TODO: Failing assertIndex(t, resp) // Should be 1 health check for the server @@ -105,6 +107,7 @@ func TestHealthServiceChecks(t *testing.T) { // Should be 1 health check for consul nodes := obj.(structs.HealthChecks) if len(nodes) != 1 { + // TODO: Failing t.Fatalf("bad: %v", obj) } } @@ -127,6 +130,8 @@ func TestHealthServiceNodes(t *testing.T) { if err != nil { t.Fatalf("err: %v", err) } + + // TODO: Failing assertIndex(t, resp) // Should be 1 health check for consul @@ -172,6 +177,8 @@ func TestHealthServiceNodes_PassingFilter(t *testing.T) { if err != nil { t.Fatalf("err: %v", err) } + + // TODO: Failing assertIndex(t, resp) // Should be 0 health check for consul diff --git a/command/agent/rpc_client_test.go b/command/agent/rpc_client_test.go index 95b7292d8720..77f34632ae4c 100644 --- a/command/agent/rpc_client_test.go +++ b/command/agent/rpc_client_test.go @@ -243,6 +243,7 @@ OUTER1: } } if !found { + // TODO: Failing t.Fatalf("should log client accept") } diff --git a/command/agent/ui_endpoint_test.go b/command/agent/ui_endpoint_test.go index ab734f3cb471..510ff973a326 100644 --- a/command/agent/ui_endpoint_test.go +++ b/command/agent/ui_endpoint_test.go @@ -100,6 +100,8 @@ func TestUiNodeInfo(t *testing.T) { if err != nil { t.Fatalf("err: %v", err) } + + // TODO: Failing assertIndex(t, resp) // Should be 1 node for the server diff --git a/consul/catalog_endpoint_test.go b/consul/catalog_endpoint_test.go index 3945dd51d92f..f4028b656177 100644 --- a/consul/catalog_endpoint_test.go +++ b/consul/catalog_endpoint_test.go @@ -540,6 +540,7 @@ func TestCatalogListServices_Timeout(t *testing.T) { // Should block at least 100ms if time.Now().Sub(start) < 100 * time.Millisecond { + // TODO: Failing t.Fatalf("too fast") }