Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of: Expose JWKS cluster config through JWTProviderConfigEntry (#17978) #18002

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Backport of: Expose JWKS cluster config through JWTProviderConfigEntry (#17978) #18002

merged 1 commit into from
Jul 4, 2023

Conversation

roncodingenthusiast
Copy link
Contributor

@roncodingenthusiast roncodingenthusiast commented Jul 4, 2023 •
edited by jmurret
Loading

Backport

Backport PR failed: #18001 so recreating it manually. The original PR was reviewed/approved here: #17978.

Description

  • Expose remote jwks cluster configuration through jwt-provider config entry to allow users to configure how remote jwks uri s are obtained.
  • We are starting with certs and connect timeout as we deem those are the most important ones currently. We will be adding more fields as we find the demand for this

Testing & Reproduction steps

  • write a jwt provider with jwks cluster
  • get the envoy config dump to ensure the cluster being configured has the right values

TODO

  • follow up this PR with docs
Overview of commits

@roncodingenthusiast
Expose JWKS cluster config through JWTProviderConfigEntry (#17978)
ba4a67f 
* Expose JWKS cluster config through JWTProviderConfigEntry

* fix typos, rename trustedCa to trustedCA
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/envoy/xds Related to Envoy support labels Jul 4, 2023
cthain
cthain approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@cthain cthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against original PR. LGTM.

@roncodingenthusiast roncodingenthusiast merged commit 7408c14 into release/1.16.x Jul 4, 2023
@roncodingenthusiast roncodingenthusiast deleted the backport-jwks-work branch July 4, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthain cthain cthain approved these changes

@kisunji kisunji kisunji approved these changes

Assignees
No one assigned
Labels
pr/no-backport theme/api Relating to the HTTP API interface theme/envoy/xds Related to Envoy support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roncodingenthusiast @kisunji @cthain