Backport of [NET-4865] security: Update Go version to 1.20.6 into release/1.14.x #18193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/zalimeni/net-4865-bump-go-cve/constantly-frank-hare
branch
2 times, most recently
from
fc04a2b to
3f8cb58
Compare
|
|
github-team-consul-core-pr-approver
approved these changes
Jul 19, 2023
zalimeni
force-pushed
the
backport/zalimeni/net-4865-bump-go-cve/constantly-frank-hare
branch
from
33e6a40 to
772a270
Compare
This resolves [CVE-2023-29406] (https://nvd.nist.gov/vuln/detail/CVE-2023-29406) for uses of the `net/http` standard library. Note that until the follow-up to #18124 is done, the version of Go used in those impacted tests will need to remain on 1.20.5. Manual backport of 93f3209.
zalimeni
force-pushed
the
backport/zalimeni/net-4865-bump-go-cve/constantly-frank-hare
branch
from
772a270 to
1c42fa5
Compare
zalimeni
requested review from
modrake and
dlaguerta
and removed request for
a team
zalimeni
deleted the
backport/zalimeni/net-4865-bump-go-cve/constantly-frank-hare
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18190 to be assessed for backporting due to the inclusion of the label backport/1.14.
🚨
The person who merged in the original PR is:
@zalimeni
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
This resolves CVE-2023-29406 for uses of the
net/httpstandard library.Note that until the follow-up to #18124 is done, the version of Go used in those impacted tests will need to remain on 1.20.5.
See related PR for
golang.org/x/netdependencies: #18186Description
Resolves CVE and brings us up to the latest version of Go.
Testing & Reproduction steps
Tests should continue to pass.
Links
https://nvd.nist.gov/vuln/detail/CVE-2023-29406
https://go-review.googlesource.com/c/go/+/506996
https://go-review.googlesource.com/c/net/+/506995
PR Checklist
Overview of commits