Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced ordered list of rate limit ops with flow diagram #18398

Merged
merged 9 commits into from
Aug 8, 2023
7 changes: 6 additions & 1 deletion website/content/docs/agent/limits/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,12 @@ Setting limits per source IP requires Consul Enterprise.

### Order of operations

You can define request rate limits in the agent configuration and in the control plane request limit configuration entry. The configuration entry also supports rate limit configurations for Consul resources. Consul perfroms the following order of operations when determing request rate limits:
You can define request rate limits in the agent configuration and in the control plane request limit configuration entry. The configuration entry also supports rate limit configurations for Consul resources. Consul performs the following order of operations when determing request rate limits:
trujillo-adam marked this conversation as resolved.
Show resolved Hide resolved

![Diagram showing the order of operations for determining request rate limits.](/img/agent-rate-limiting-ops-order.jpg#light-theme-only)
![Diagram showing the order of operations for determining request rate limits.](/img/agent-rate-limiting-ops-order-dark.jpg#dark-theme-only)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the dark mode coloring is kinda off?

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, OK. I'll have another look -- this is just how the slides spit it out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was actually using the wrong the slides --- we don't have the ability to do portrait, so I made a copy (of the wrong slides) and followed the instructions there.

trujillo-adam marked this conversation as resolved.
Show resolved Hide resolved

<!--
1. Parse request.
1. Does the request reach a global server limit?
- No: Proceed to the next stage.
Expand All @@ -50,6 +54,7 @@ You can define request rate limits in the agent configuration and in the control
- No: Proceed to the next stage.
- Yes: Return an error that the requested resource has been exhausted.
1. Handle the request.
-->

## Kubernetes

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.