Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Apigee for ext_authz, minor fix in the default ext_authz docs #18796
Adding Apigee for ext_authz, minor fix in the default ext_authz docs #18796
Changes from 2 commits
9512348
0f66724
d932e8f
f0d753b
0fca72f
80ccf2d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per comment above, there is an inconsistency between the steps as described above and this heading. I'm not certain which is intended to be correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @boruszak! very helpful, let me know how the latest commit looks.
I didn't write the full statements in workflows as headings because they we too long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add more to this description of the example below? I don't quite understand what you mean to say here because the
apigee-remote-service-envoy
service isn't mentioned in this description. Try the following format:"The following example configures a default behavior for all services named
api
so that the Envoy proxies running as sidecars for those service instances target theapigee-remote-service-envoy
service for gRPC authorization requests."I'm not sure if that's correct - just trying to demonstrate
names-in-code-font
mixed with terms in the example config (defaults, target, gRPC) as a way to fully describe what the configuration does.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is correct and that actually sounds much better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @boruszak