Adds discovery_max_stale #4004
Merged
Adds discovery_max_stale #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following conversation #3911 This patch allow to change the default behavior of Consul regarding consistency
…lelism to avoid timing issues on their contended CPUs
…delay gathering packages until the makefile
This avoids a conflict with #datacenter later on the page. We're mixing histroic manually specified anchors with generated anchors (via redcarpet / middleman-hashicorp) so we have to manually override the automatic generation here. I was tempted to rewrite the old manual anchors to use the automatic generation, but there is no way to maintain backwards compatibility, so will leave that for a time when it is appropriate for us to break links (or redirect them, etc). Fixes #3916
Minor fixes (typos in comments) Removed fmt.Printf debug code Added documentation to new option
| @@ -461,6 +461,14 @@ type RuntimeConfig struct { | |||
| // flag: -datacenter string | |||
| Datacenter string | |||
|
|
|||
| // Defines the maximum stale value for discovery path. Defauls to "0s". | |||
| // Discovery paths are /v1/heath/ paths | |||
|
@preetapan @pierresouchay Very useful! 🏅 Have you considered switching the default to In my view it makes sense to mirror stale-logic for DNS and HTTP discovery requests. However, there may be good reasons to not do that, which I'm unaware of. Curious to hear your thoughts! |
|
@sandstrom Agree with you, you can follow conversation here: #3911 and #3920 On our side, we are using it with very long values in a similar way to DNS As you suggested, this is a breaking change, so not for a 1.x version |
|
@pierresouchay Thanks, I've read those too! Let's see what @preetapan says about flipping the default in the next major. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #3920