Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make limits a reloadable configuration #4019

Merged
merged 2 commits into from
Jun 20, 2018
Merged

Make limits a reloadable configuration #4019

merged 2 commits into from
Jun 20, 2018

Conversation

jwasinger
Copy link
Contributor

@jwasinger jwasinger commented Apr 8, 2018 •
edited
Loading

I have provided unit tests. Now I will implement the changes. fixes #4012

@jwasinger jwasinger force-pushed the reload-config-limits branch from 35375f5 to 826becf Compare April 8, 2018 10:42
@jwasinger jwasinger force-pushed the reload-config-limits branch from cde5c06 to 255492b Compare April 8, 2018 10:57
@mkeeler
Copy link
Member

mkeeler commented Apr 9, 2018

Thanks for the PR @jwasinger.

@pearkes
Copy link
Contributor

pearkes commented Apr 27, 2018

@jwasinger do you plan on picking this up again or do you need review (still seeing WIP in the description here). If not, we can close this out and you're welcome to open a new PR down the road. Let us know!

@jwasinger
Copy link
Contributor Author

Sorry @pearkes , got caught up in other work and forgot to update the PR description. I think this one is ready for review.

@guidoiaquinti
Copy link
Contributor

@pearkes can we target this PR for the next release? 🙏

@pearkes pearkes added this to the 1.2.0 milestone May 25, 2018
@mkeeler mkeeler mentioned this pull request Jun 11, 2018
Merged
@mkeeler
Copy link
Member

mkeeler commented Jun 11, 2018

@jwasinger Thanks for your work on this. There were a few things regarding how to go about actually applying those limits that still needed thinking through and working out. Instead of dictating what code to write I checked out your branch made the necessary changes and have a second PR open: #4216. When that other PR lands with both our changes in it I will close both of these.

@mkeeler mkeeler merged commit 672a2a3 into hashicorp:master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Make limits a reloadable configuration
4 participants
@jwasinger @mkeeler @pearkes @guidoiaquinti