From e18f593f26a65bb89cf1506737dfc95df7a2a7d2 Mon Sep 17 00:00:00 2001 From: Cristiano Rastelli Date: Thu, 13 Apr 2023 15:42:31 +0100 Subject: [PATCH] updated per code review suggestions --- .../tests/integration/components/hds/app-frame/index-test.js | 2 -- website/app/components/doc/page/sidebar.js | 2 +- website/app/controllers/components.js | 2 +- website/app/templates/components.hbs | 4 ++-- website/lib/markdown/table-of-contents.js | 2 +- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/components/tests/integration/components/hds/app-frame/index-test.js b/packages/components/tests/integration/components/hds/app-frame/index-test.js index d41adcca1ce..ec95aea8b98 100644 --- a/packages/components/tests/integration/components/hds/app-frame/index-test.js +++ b/packages/components/tests/integration/components/hds/app-frame/index-test.js @@ -39,8 +39,6 @@ module('Integration | Component | hds/app-frame/index', function (hooks) { `); - // await pauseTest(); - assert.dom('#test-app-frame[data-test-app-frame]').exists(); assert.dom('#test-app-frame-header[data-test-app-frame-header]').exists(); diff --git a/website/app/components/doc/page/sidebar.js b/website/app/components/doc/page/sidebar.js index 2a7403dcf1f..ac38cb20f71 100644 --- a/website/app/components/doc/page/sidebar.js +++ b/website/app/components/doc/page/sidebar.js @@ -16,7 +16,7 @@ const DEBOUNCE_MS = 250; const getTocSectionsBundle = (section) => { const ABOUT = ['about', 'getting-started']; const FOUNDATIONS = ['foundations', 'icons']; - const COMPONENTS = ['components', 'overrides', 'layouts', 'utilities']; + const COMPONENTS = ['components', 'layouts', 'overrides', 'utilities']; const PATTERNS = ['patterns']; // this will be removed later const TESTING = ['testing']; diff --git a/website/app/controllers/components.js b/website/app/controllers/components.js index d1f6b5e49dc..2ff128bc0f7 100644 --- a/website/app/controllers/components.js +++ b/website/app/controllers/components.js @@ -9,7 +9,7 @@ export default class ComponentsController extends Controller { get cards() { // we want to use a flat tree here... const tocTree = this.model.toc.flat; - const sections = ['components', 'overrides', 'layouts', 'utilities']; + const sections = ['components', 'layouts', 'overrides', 'utilities']; const cards = {}; sections.forEach((section) => { cards[section] = tocTree diff --git a/website/app/templates/components.hbs b/website/app/templates/components.hbs index 9ccd4dd31c6..bfc49d7503d 100644 --- a/website/app/templates/components.hbs +++ b/website/app/templates/components.hbs @@ -9,10 +9,10 @@ -

Overrides

-

Layouts

+

Overrides

+

Utilities

diff --git a/website/lib/markdown/table-of-contents.js b/website/lib/markdown/table-of-contents.js index 5f3c4859959..3b04c74abc1 100644 --- a/website/lib/markdown/table-of-contents.js +++ b/website/lib/markdown/table-of-contents.js @@ -14,8 +14,8 @@ const CATEGORIES = [ 'updates', 'foundations', 'components', - 'overrides', 'layouts', + 'overrides', 'utilities', 'patterns', 'testing',