diff --git a/client.go b/client.go index 2a178ccf3..3fd49d542 100644 --- a/client.go +++ b/client.go @@ -40,12 +40,8 @@ func (c *Client) Get(ctx context.Context, req *Request) (*Operation, error) { } // Store this locally since there are cases we swap this - if req.Mode == ClientModeInvalid { - if req.Dir { - req.Mode = ClientModeDir - } else { - req.Mode = ClientModeFile - } + if req.Mode == ModeInvalid { + req.Mode = ModeAny } var err error diff --git a/client_option_progress_test.go b/client_option_progress_test.go index a7b644dc2..8309f9091 100644 --- a/client_option_progress_test.go +++ b/client_option_progress_test.go @@ -54,7 +54,6 @@ func TestGet_progress(t *testing.T) { Dst: dst, Src: s.URL + "/file?thig=this&that", ProgressListener: p, - Dir: false, } if _, err := DefaultClient.Get(ctx, req); err != nil { t.Fatalf("download failed: %v", err) @@ -63,7 +62,6 @@ func TestGet_progress(t *testing.T) { Dst: dst, Src: s.URL + "/otherfile?thig=this&that", ProgressListener: p, - Dir: false, } if _, err := DefaultClient.Get(ctx, req); err != nil { t.Fatalf("download failed: %v", err) diff --git a/get_git.go b/get_git.go index f08435ae2..4a0b044f7 100644 --- a/get_git.go +++ b/get_git.go @@ -28,7 +28,7 @@ type GitGetter struct { var defaultBranchRegexp = regexp.MustCompile(`\s->\sorigin/(.*)`) -func (g *GitGetter) ClientMode(_ context.Context, u *url.URL) (ClientMode, error) { +func (g *GitGetter) Mode(_ context.Context, u *url.URL) (Mode, error) { return ModeDir, nil } diff --git a/get_git_test.go b/get_git_test.go index fde606863..eedba0ed4 100644 --- a/get_git_test.go +++ b/get_git_test.go @@ -409,7 +409,7 @@ func TestGitGetter_sshSCPStyle(t *testing.T) { Dst: dst, Pwd: ".", - Mode: ClientModeDir, + Mode: ModeDir, } client := &Client{ Detectors: []Detector{ @@ -452,7 +452,7 @@ func TestGitGetter_sshExplicitPort(t *testing.T) { Dst: dst, Pwd: ".", - Mode: ClientModeDir, + Mode: ModeDir, } client := &Client{ @@ -496,7 +496,7 @@ func TestGitGetter_sshSCPStyleInvalidScheme(t *testing.T) { Dst: dst, Pwd: ".", - Mode: ClientModeDir, + Mode: ModeDir, } client := &Client{ diff --git a/get_test.go b/get_test.go index f6ad424f8..1f6fad522 100644 --- a/get_test.go +++ b/get_test.go @@ -753,8 +753,7 @@ func TestGetFile_inplace_badChecksum(t *testing.T) { if err == nil { t.Fatalf("err is nil") } - _, ok := err.(*ChecksumError) - if ok == false { + if _, ok := err.(*ChecksumError); !ok { t.Fatalf("err is not a checksum error: %v", err) } if op != nil {