[fix] Windows junction handling #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritikrajdev
reviewed
Sep 9, 2025
This was referenced Sep 11, 2025
ritikrajdev
approved these changes
Sep 15, 2025
|
|
||
| # Project-specific binaries | ||
| cmd/go-getter/go-getter | ||
| go-getter |
There was a problem hiding this comment.
just want to confirm if we're ignoring go-getter binary or a directory named go-getter over here?
any specific reason why we're ignoring this>?
Member
Author
There was a problem hiding this comment.
there to keep the compiled go-getter binary out of version control
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
Fix Windows Test Coverage and Implement Cross-Platform Symlink Resolution
This PR addresses two key areas to improve the robustness and test coverage of go-getter on Windows:
Previously, several important tests were being skipped on Windows, reducing test coverage and potentially hiding Windows-specific issues.
Cross-Platform Symlink Resolution
Implemented new symlink resolution infrastructure to handle the complexities of Windows filesystem links:
All previously skipped Windows tests now pass