Set gzip compression level to BestSpeed (1) #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonc
force-pushed
the
brandonc/best_speed
branch
from
d21bbba to
06dbc3c
Compare
We notice that compression time far exceeds upload time in practice, and think it should be re-balanced toward less compression
brandonc
force-pushed
the
brandonc/best_speed
branch
from
06dbc3c to
880d846
Compare
annawinkler
approved these changes
Nov 8, 2022
annawinkler
left a comment
annawinkler
left a comment
There was a problem hiding this comment.
This looks OK to me, but I'd really like someone more familiar with the repo to also review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We notice that compression time far exceeds upload time in practice, and think it should be re-balanced toward less compression. I have some analytics that I can share that illustrate this in downstream tfc-agent.