nomad run should return non-zero exit code in case of any errors

[pznamensky]

Proposal

Return non-zero exit code in case of any errors during deploying an app.

Use-cases

We switched to nomad run from levant deploy in our CI scripts, but we noticed, that nomad run can return code 0 even when a deployment is failed:

~ $ nomad run my-app.nomad
...
2021-08-25T16:53:10+03:00
ID          = 098fb4b6
Job ID      = my-app
Job Version = 0
Status      = failed
Description = Failed due to progress deadline

Deployed
Task Group  Desired  Placed  Healthy  Unhealthy  Progress Deadline
my-app         1        1       0        1          2021-08-25T16:53:10+03:00

~ $ echo $?
0

Attempted Solutions

Return non-zero code in case of any failures :)

[goku321]

I'm new to nomad but have experience with Go and k8s. Can I work on this?

[mikenomitch]

Hey @goku321, please feel free to take this one. We would love to see a community PR for this!

Because this changes the external interface for the command, I think we might wait to implement this until a major release, but I think this is a good idea.

Good luck!

[goku321]

Thank you, @mikenomitch

[tgross]

Fixed in #11550 and will ship in the next planned patch release.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.