Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: Improve namespace and region support #11269

Merged
merged 24 commits into from
Oct 12, 2021
Merged

debug: Improve namespace and region support #11269

merged 24 commits into from
Oct 12, 2021

Conversation

davemay99
Copy link
Contributor

This PR provides additional insight into namespaces and regions known to the cluster.

  • Add namespace/region filter to CLI output
  • Add region filtering for servers
  • Add namespaces.json and regions.json to cluster meta
  • Add helper function to test for presence of string prefix in slice of strings
  • Refactor tests to validate correct behavior

@vercel vercel bot temporarily deployed to Preview – nomad October 6, 2021 03:26 Inactive
@davemay99 davemay99 requested a review from notnoop October 6, 2021 15:12
notnoop
notnoop reviewed Oct 6, 2021
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usability improvement is pretty nice. I have few stylistic comments as well as a question about SliceStringContainsPrefix logic.

command/operator_debug.go Outdated Show resolved Hide resolved
command/operator_debug.go Show resolved Hide resolved
command/operator_debug.go Outdated Show resolved Hide resolved
command/operator_debug.go Outdated Show resolved Hide resolved
command/operator_debug_test.go Outdated Show resolved Hide resolved
command/operator_debug_test.go Outdated Show resolved Hide resolved
command/operator_debug_test.go Outdated Show resolved Hide resolved
helper/funcs.go Outdated Show resolved Hide resolved
command/operator_debug_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nomad October 7, 2021 01:18 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad October 12, 2021 02:41 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad October 12, 2021 05:31 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad October 12, 2021 06:22 Inactive
@davemay99
Copy link
Contributor Author

@notnoop I think I have resolved all of the points you raised, as well as smashing some other bugs encountered along the way. Can you take another look when you have a moment and let me know if there are any remaining issues?

notnoop
notnoop approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! I like the new test helpers you added too! Thanks for your patience working through my many comments!

helper/funcs_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nomad October 12, 2021 20:26 Inactive
@davemay99 davemay99 merged commit 1bd132f into main Oct 12, 2021
@davemay99 davemay99 deleted the b-debug-region-namespaces branch October 12, 2021 20:58
@davemay99 davemay99 added this to the 1.2.0 milestone Oct 13, 2021
lgfa29 pushed a commit that referenced this pull request Nov 15, 2021
@davemay99 @lgfa29
debug: Improve namespace and region support (#11269)
8b0daa4 
* Include region and namespace in CLI output
* Add region and prefix matching for server members
* Add namespace and region API outputs to cluster metadata folder
* Add region awareness to WaitForClient helper function
* Add helper functions for SliceStringHasPrefix and StringHasPrefixInSlice
* Refactor test client agent generation
* Add tests for region
* Add changelog
lgfa29 pushed a commit that referenced this pull request Nov 15, 2021
@davemay99 @lgfa29
debug: Improve namespace and region support (#11269)
0e3c0bf 
* Include region and namespace in CLI output
* Add region and prefix matching for server members
* Add namespace and region API outputs to cluster metadata folder
* Add region awareness to WaitForClient helper function
* Add helper functions for SliceStringHasPrefix and StringHasPrefixInSlice
* Refactor test client agent generation
* Add tests for region
* Add changelog
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notnoop notnoop notnoop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@davemay99 @notnoop @lgfa29