api: use cleanhttp.DefaultPooledTransport for default API client
#12492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
api-default-pooled-client
branch
from
855e3d2
to
b9d9bf3
Compare
tgross
requested review from
schmichael and
DerekStrickland
and removed request for
DerekStrickland
We expect every Nomad API client to use a single connection to any given agent, so take advantage of keep-alive by switching the default transport to `DefaultPooledClient`. Provide a facility to close idle connections for testing purposes. Restores the previously reverted #12409 Co-authored-by: Ben Buzbee <bbuzbee@cloudflare.com>
tgross
force-pushed
the
api-default-pooled-client
branch
from
b9d9bf3
to
cf039e7
Compare
DerekStrickland
approved these changes
Apr 6, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect every Nomad API client to use a single connection to any
given agent, so take advantage of keep-alive by switching the default
transport to
DefaultPooledClient. Provide a facility to close idleconnections for testing purposes.
Restores the previously reverted #12409 (cc @benbuzbee)