Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] notify systemd after agent has joined the cluster #4466

Closed
jrasell opened this issue Jul 3, 2018 · 8 comments
Closed

[feature] notify systemd after agent has joined the cluster #4466

jrasell opened this issue Jul 3, 2018 · 8 comments

Comments

@jrasell
Copy link
Member

jrasell commented Jul 3, 2018

In the same style that Consul integrated, it would be nice if Nomad could have the potential to notify systemd when the agent has successfully joined the cluster and is operational. This would allow dependant services to be correctly chained off Nomad rather than blindly starting assuming the service is OK.

Consul PR - hashicorp/consul@31a310f
Consul Issue - hashicorp/consul#2121

I am happy to raise a PR for this if you believe its a worthwhile addition but have a few questions:

  • preference on importing the Consul implementation systemd package or writing a custom Nomad one
  • exactly where successful startup and join of an agent would be considered for notification
@nickethier
Copy link
Member

Hey @jrasell

Thanks for raising this issue. I'd advise holding off on any immediate work as there some work in progress that could affect this. I think this may benefit from some work we're doing to support external plugins. This is a valuable use case to identify and will help add perspective.

@jippi
Copy link
Contributor

jippi commented Dec 6, 2018

@nickethier any news on this?

@stale
Copy link

stale bot commented May 10, 2019

Hey there

Since this issue hasn't had any activity in a while - we're going to automatically close it in 30 days. If you're still seeing this issue with the latest version of Nomad, please respond here and we'll keep this open and take another look at this.

Thanks!

@jrasell
Copy link
Member Author

jrasell commented May 10, 2019

Please keep open.

@elcomtik
Copy link

@nickethier any news?

I have an issue with dependency for vault-agent and experiencing exactly this issue #3885

I'm reloading nomad by vault-agent service, so I wanted to patch this by defining systemd service order. However, this is useless because the systemd unit for nomad is using Type simple, which doesn't wait for service startup. I tried to use types forking and notify, however, nomad doesn't support them also.

Support for proper systems notification is essential for proper integration with vault-agent which reloads nomad for ACL token renewal. This makes life with enabled ACL unnecessarily hard.

@elcomtik
Copy link

elcomtik commented Feb 6, 2023

Support for proper systems notification is essential for proper integration with vault-agent which reloads nomad for ACL token renewal. This makes life with enabled ACL unnecessarily hard.

@tgross This still bothers me, are there any plans for it? Thanks for your response.

@tgross
Copy link
Member

tgross commented Jul 26, 2024

Shipped in Nomad 1.8.0: #20528

@tgross tgross closed this as completed Jul 26, 2024
@tgross tgross added this to the 1.8.0 milestone Jul 26, 2024
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants