docs: warn not to set network_mode for Connect-enabled Docker task
#10724
Conversation
tgross
added
theme/docs
| The default `network_mode` for tasks that use [Connect] will be | ||
| `container:<name>`, where the name is the container name of the parent | ||
| container used to share network namespaces between tasks. You should not set | ||
| `network_mode` for Connect-enabled tasks. |
There was a problem hiding this comment.
What happens now when it's set? Should we add some validation/warning logic in the docker driver too?
There was a problem hiding this comment.
Your task can't reach the Envoy proxy and can't be reached over the Envoy proxy. I do want to add a warning but it's one of those annoying scenarios where the enforcement will be all client-side because it's in the driver config. In any case, I want to do any code changes to improve that in a separate PR. Also, I do worry that I haven't considered some weird corner case where you'd want to do that?
There was a problem hiding this comment.
I've opened #10725 for the driver change, just in case I don't get to it right away.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This warning comes out of #8900 and other issues where the correct configuration for
network_modeof Connect-enableddockerdriver tasks is a little unclear.