Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of metrics: classless blocked evals get metrics into release/1.3.x #13807

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #13786 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


This PR fixes a bug where blocked evaluations with no class set would
not have metrics exported at the dc:class scope.

Fixes #13759

Also drive-by fixup naming of ByNode to ByClassInDC which is more accurate 🤦

Backport to 1.3.x, 1.2.x

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-metrics-for-classless-blocked-evals/unduly-settled-marmoset branch from 8f8ee39 to 1319e83 Compare July 18, 2022 12:34
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 39e041d into release/1.3.x Jul 18, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-metrics-for-classless-blocked-evals/unduly-settled-marmoset branch July 18, 2022 12:35
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants