Update to Raft V2 stage one #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
reviewed
Feb 6, 2017
| s.logger.Printf("[INFO] nomad: Attempting bootstrap with nodes: %v", addrs) | ||
| if err := s.raft.SetPeers(addrs).Error(); err != nil { | ||
| s.logger.Printf("[ERR] nomad: failed to bootstrap peers: %v", err) | ||
| // Attempt a live bootstrap! |
There was a problem hiding this comment.
In a later commit I ended up adding an additional check here. This isn't strictly required, but helps prevent spurious leader elections if another server is added later - hashicorp/consul#2319.
| peersTimeout.Reset(peersPollInterval + lib.RandomStagger(peersPollInterval/peersPollJitterFactor)) | ||
| return nil | ||
| } | ||
| } | ||
| consulQueryCount++ | ||
|
|
||
| s.logger.Printf("[DEBUG] server.consul: lost contact with Nomad quorum, falling back to Consul for server list") |
nomad/server.go
Outdated
| after an outage. It should be formatted as a JSON array containing the address | ||
| and port of each Consul server in the cluster, like this: | ||
|
|
||
| ["10.1.0.1:8500","10.1.0.2:8500","10.1.0.3:8500"] |
There was a problem hiding this comment.
These were wrong in the initial PR for Consul, and don't look right for Nomad. Should update these port numbers.
nomad/server.go
Outdated
|
|
||
| Under normal operation, the peers.json file will not be present. | ||
|
|
||
| When Consul starts for the first time, it will create this peers.info file and |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Nomad to use Raft V2, Stage One.