Revert go-getter update #26731
Merged
Revert go-getter update #26731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a96929.
tgross
added
backport/ent/1.10.x+ent
dduzgun-security
previously approved these changes
Sep 8, 2025
tgross
dismissed stale reviews from gulducat and dduzgun-security
via
51d3bd4
gulducat
previously approved these changes
Sep 8, 2025
tgross
added a commit
that referenced
this pull request
Sep 9, 2025
The `go-getter` update in #26713 is not passing tests upstream (apparently hashicorp/go-getter#548 is the origin of the problem but that PR did not ever run tests). The issue being fixed isn't a critical vulnerability, so in the interest of preparing us for the next release, revert the `go-getter` change but keep the Go toolchain update. We'll skip go-getter 1.8.0 and pick up the next patch version once its issues are fixed. Reverts commit 8a96929.
tgross
added a commit
that referenced
this pull request
Sep 9, 2025
The `go-getter` update in #26713 is not passing tests upstream (apparently hashicorp/go-getter#548 is the origin of the problem but that PR did not ever run tests). The issue being fixed isn't a critical vulnerability, so in the interest of preparing us for the next release, revert the `go-getter` change but keep the Go toolchain update. We'll skip go-getter 1.8.0 and pick up the next patch version once its issues are fixed. Reverts commit 8a96929. Co-authored-by: Tim Gross <tgross@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go-getterupdate in #26713 is not passing tests upstream (apparently hashicorp/go-getter#548 is the origin of the problem but that PR did not ever run tests). The issue being fixed isn't a critical vulnerability, so in the interest of preparing us for the next release, revert thego-getterchange but keep the Go toolchain update.We'll skip go-getter 1.8.0 and pick up the next patch version once its issues are fixed.