Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tags from InstanceMetadataOptionsRequest when in the default state to fix launch issue for unsupported regions #244

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

nywilken
Copy link
Contributor

The ability to include instance tags within the instance metadata
service is not supported for non-commercial regions such as GovCloud.
This change will only include the configuration for instances metadata
tags when enabled. By default, where supported, unspecified settings
will use the default API value of "disabled". Enabling support for tags
in a unsupported region will result in an AWS launch error, which will
terminate the build.

Closes #242

…tate

The ability to include instance tags within the instance metadata
service is not supported for non-commercial regions such as GovCloud.
This change will only include the configuration for instances metadata
tags when enabled. By default, where supported, unspecified settings
will use the default API value of "disabled". Enabling support for tags
in a unsupported region will result in an AWS launch error, which will
terminate the build.

Closes #242
@nywilken nywilken requested a review from a team as a code owner July 26, 2022 17:36
@nywilken nywilken added the bug label Jul 26, 2022
@nywilken nywilken changed the title Remove tags from InstanceMetadataOptionsRequest when in the default state Remove tags from InstanceMetadataOptionsRequest when in the default state to fix launch issue for unsupported regions Jul 26, 2022
Copy link
Contributor

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@nywilken nywilken merged commit a9b8ffc into main Jul 27, 2022
@nywilken nywilken deleted the fix-instance-metadata-tags branch July 27, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance metadata tags are not supported in all regions
2 participants