feat: add platform flag for ec2 image import task #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lbajolet-hashicorp
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Hi @GastroGee,
Thanks for opening this PR! I left a couple suggestions regarding the default value for the attribute, I propose leaving it empty by default, unless this is required (i.e. if boot_mode is set).
Other than that, the implementation makes sense.
Out of curiosity, have you tested this on a template? Does that fix the problem?
Thanks again for addressing this bug!
… is set in boot_mode
lbajolet-hashicorp
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Hi @GastroGee,
The code looks good to me, there's some errors at build-time though, could you fix those and re-submit?
Once that's done, we can merge this, thanks!
lbajolet-hashicorp
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting platform for the image-import task fixes a bug where the process gets stuck as mentioned in #433
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
Closes #433