-
Notifications
You must be signed in to change notification settings - Fork 62
Add GHA for running acceptance test nightly #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
schedule: | ||
# Runs against the default branch every day at midnight | ||
- cron: "0 0 * * *" | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added for testing purposes. I would like to run the action manually to ensure all is working as expected.
4b54af2
to
02e81aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the manual triggering will be removed when the action is tested?
Otherwise the code looks good to me, I can approve this when the workflow_dispatch
has been taken care of.
run: | | ||
mkdir -p /tmp/test-results | ||
make dev | ||
PACKER_ACC=1 gotestsum --format=short-verbose --junitfile /tmp/test-results/gotestsum-report.xml -- -count=1 -timeout=120m -p 2 ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may miss something, but will we do anything with the junitfile? Should it be uploaded somewhere, or do we ignore it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. This is copy pasta. We don't do anything with. So I would say it is safe to remove.
In an attempt to test the latest code changes against the latest released version of Packer a GitHub action is being added to run nightly acceptance tests. Authentication for this action is controlled by repository secrets, which are exposed to the Packer runner by setting the GOOGLE_APPLICATION_CREDENTIALS environment variable. * Added a .go-version file to control the version of Go used for testing
02e81aa
to
4faafe1
Compare
Thanks all is green and working as expected. I removed the workflow_dispatch |
In an attempt to test the latest code changes against the latest released version of Packer a GitHub action is being added to run nightly acceptance tests. Authentication for this action is controlled by repository secrets, which are exposed to the Packer runner by setting the GOOGLE_APPLICATION_CREDENTIALS environment variable. * Added a .go-version file to control the version of Go used for testing
In an attempt to test the latest code changes against the latest released version of Packer a GitHub action is being added to run nightly acceptance tests. Authentication for this action is controlled by repository secrets, which are exposed to the Packer runner by setting the GOOGLE_APPLICATION_CREDENTIALS environment variable.