Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ~/ with UserHomeDir if the value of synced_folder has the prefix '~/' #69

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Replace ~/ with UserHomeDir if the value of synced_folder has the prefix '~/' #69

merged 1 commit into from
Jan 11, 2023

Conversation

smaruy30
Copy link
Contributor

Description

If one sets the value of the synced_folder as ~/dir, packer responds an error which is shown in #68.
This PR is to solve the error.

Test Results

$ make test
?   	github.com/hashicorp/packer-plugin-vagrant	[no test files]
ok  	github.com/hashicorp/packer-plugin-vagrant/builder/vagrant	1.532s
ok  	github.com/hashicorp/packer-plugin-vagrant/post-processor/vagrant	1.547s
ok  	github.com/hashicorp/packer-plugin-vagrant/post-processor/vagrant-cloud	1.938s
?   	github.com/hashicorp/packer-plugin-vagrant/version	[no test files]

Closes #68

@smaruy30 smaruy30 requested a review from a team as a code owner October 24, 2022 08:06
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 24, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@smaruy30 smaruy30 changed the title [WIP] replace ~/ with UserHomeDir if the value of synced_folder has the prefix '~/' replace ~/ with UserHomeDir if the value of synced_folder has the prefix '~/' Oct 31, 2022
@smaruy30 smaruy30 changed the title replace ~/ with UserHomeDir if the value of synced_folder has the prefix '~/' Replace ~/ with UserHomeDir if the value of synced_folder has the prefix '~/' Oct 31, 2022
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smaruy30,

LGTM, thanks for the fix!

@lbajolet-hashicorp lbajolet-hashicorp merged commit c6603b8 into hashicorp:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The synced_folder option does not expand ~/
3 participants
@smaruy30 @hashicorp-cla @lbajolet-hashicorp