rds/orderable_instance: Improve performance

hashicorp · Feb 9, 2024 · 6154e5f · 6154e5f
1 parent c0a95af
commit 6154e5f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/internal/service/rds/orderable_instance_data_source.go b/internal/service/rds/orderable_instance_data_source.go
@@ -213,7 +213,9 @@ func dataSourceOrderableInstanceRead(ctx context.Context, d *schema.ResourceData
  var diags diag.Diagnostics
  conn := meta.(*conns.AWSClient).RDSConn(ctx)
 
- input := &rds.DescribeOrderableDBInstanceOptionsInput{}
+ input := &rds.DescribeOrderableDBInstanceOptionsInput{
+ MaxRecords: aws.Int64(3412),
+ }
 
  if v, ok := d.GetOk("availability_zone_group"); ok {
  input.AvailabilityZoneGroup = aws.String(v.(string))
@@ -463,8 +465,6 @@ func dataSourceOrderableInstanceRead(ctx context.Context, d *schema.ResourceData
  return sdkdiag.AppendErrorf(diags, "no RDS DB Instance Classes match the criteria; try a different search")
  }
 
- //fmt.Printf("found: %s, %s\n", aws.StringValue(found.DBInstanceClass), aws.StringValue(found.EngineVersion))
-
  d.SetId(aws.StringValue(found.DBInstanceClass))
  d.Set("availability_zone_group", found.AvailabilityZoneGroup)
  var availabilityZones []string

diff --git a/internal/service/rds/orderable_instance_data_source_test.go b/internal/service/rds/orderable_instance_data_source_test.go
@@ -242,7 +242,7 @@ func TestAccRDSOrderableInstanceDataSource_readReplicaCapable(t *testing.T) {
  resource.TestCheckResourceAttr(dataSourceName, "read_replica_capable", "true"),
  resource.TestCheckResourceAttr(dataSourceName, "engine", tfrds.InstanceEngineOracleEnterprise),
  resource.TestCheckResourceAttr(dataSourceName, "engine_latest_version", "true"),
- resource.TestMatchResourceAttr(dataSourceName, "instance_class", regexache.MustCompile(`^db\..*large$`)),
+ resource.TestCheckResourceAttrSet(dataSourceName, "instance_class"),
  ),
  },
  },