add partition checks to service principal data source tests

hashicorp · Sep 19, 2024 · 98c4258 · 98c4258
1 parent 3339833
commit 98c4258
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/internal/service/meta/region_data_source_test.go b/internal/service/meta/region_data_source_test.go
@@ -15,7 +15,7 @@ import (
  "github.com/hashicorp/terraform-provider-aws/names"
 )
 
-func TestAccMetaRegionDataSource_FindRegionByEndpoint(t *testing.T) {
+func TestAccMetaRegionDataSource_FindRegionByEC2Endpoint(t *testing.T) {
  t.Parallel()
 
  ctx := acctest.Context(t)

diff --git a/internal/service/meta/service_principal_data_source_test.go b/internal/service/meta/service_principal_data_source_test.go
@@ -63,7 +63,7 @@ func TestAccMetaServicePrincipal_ByRegion(t *testing.T) {
  t.Run(region, func(t *testing.T) {
  t.Parallel()
  resource.Test(t, resource.TestCase{
- PreCheck: func() { acctest.PreCheck(ctx, t) },
+ PreCheck: func() { acctest.PreCheck(ctx, t); acctest.PreCheckPartition(t, names.PartitionForRegion(region)) },
  ErrorCheck: acctest.ErrorCheck(t, tfmeta.PseudoServiceID),
  ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
  Steps: []resource.TestStep{
@@ -135,7 +135,10 @@ func TestAccMetaServicePrincipal_UniqueForServiceInRegion(t *testing.T) {
  t.Run(fmt.Sprintf("%s/%s", testCase.Region, testCase.Service), func(t *testing.T) {
  t.Parallel()
  resource.Test(t, resource.TestCase{
- PreCheck: func() { acctest.PreCheck(ctx, t) },
+ PreCheck: func() {
+ acctest.PreCheck(ctx, t)
+ acctest.PreCheckPartition(t, names.PartitionForRegion(testCase.Region))
+ },
  ErrorCheck: acctest.ErrorCheck(t, tfmeta.PseudoServiceID),
  ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
  Steps: []resource.TestStep{