-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
d/rds_engine_version: New data source
- Loading branch information
Showing
4 changed files
with
415 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,251 @@ | ||
package aws | ||
|
||
import ( | ||
"fmt" | ||
"log" | ||
|
||
"github.com/aws/aws-sdk-go/aws" | ||
"github.com/aws/aws-sdk-go/service/rds" | ||
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema" | ||
) | ||
|
||
func dataSourceAwsRdsEngineVersion() *schema.Resource { | ||
return &schema.Resource{ | ||
Read: dataSourceAwsRdsEngineVersionRead, | ||
Schema: map[string]*schema.Schema{ | ||
"default_character_set": { | ||
Type: schema.TypeString, | ||
Computed: true, | ||
}, | ||
|
||
"engine": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
}, | ||
|
||
"engine_description": { | ||
Type: schema.TypeString, | ||
Computed: true, | ||
}, | ||
|
||
"exportable_log_types": { | ||
Type: schema.TypeSet, | ||
Elem: &schema.Schema{Type: schema.TypeString}, | ||
Computed: true, | ||
Set: schema.HashString, | ||
}, | ||
|
||
"parameter_group_name": { | ||
Type: schema.TypeString, | ||
Computed: true, | ||
Optional: true, | ||
}, | ||
|
||
"preferred_versions": { | ||
Type: schema.TypeList, | ||
Optional: true, | ||
Elem: &schema.Schema{Type: schema.TypeString}, | ||
ConflictsWith: []string{"version"}, | ||
}, | ||
|
||
"status": { | ||
Type: schema.TypeString, | ||
Computed: true, | ||
}, | ||
|
||
"supported_character_sets": { | ||
Type: schema.TypeSet, | ||
Elem: &schema.Schema{Type: schema.TypeString}, | ||
Computed: true, | ||
Set: schema.HashString, | ||
}, | ||
|
||
"supported_feature_names": { | ||
Type: schema.TypeSet, | ||
Elem: &schema.Schema{Type: schema.TypeString}, | ||
Computed: true, | ||
Set: schema.HashString, | ||
}, | ||
|
||
"supported_modes": { | ||
Type: schema.TypeSet, | ||
Elem: &schema.Schema{Type: schema.TypeString}, | ||
Computed: true, | ||
Set: schema.HashString, | ||
}, | ||
|
||
"supported_timezones": { | ||
Type: schema.TypeSet, | ||
Elem: &schema.Schema{Type: schema.TypeString}, | ||
Computed: true, | ||
Set: schema.HashString, | ||
}, | ||
|
||
"supports_global_databases": { | ||
Type: schema.TypeBool, | ||
Computed: true, | ||
}, | ||
|
||
"supports_log_exports_to_cloudwatch": { | ||
Type: schema.TypeBool, | ||
Computed: true, | ||
}, | ||
|
||
"supports_parallel_query": { | ||
Type: schema.TypeBool, | ||
Computed: true, | ||
}, | ||
|
||
"supports_read_replica": { | ||
Type: schema.TypeBool, | ||
Computed: true, | ||
}, | ||
|
||
"valid_upgrade_targets": { | ||
Type: schema.TypeSet, | ||
Elem: &schema.Schema{Type: schema.TypeString}, | ||
Computed: true, | ||
Set: schema.HashString, | ||
}, | ||
|
||
"version": { | ||
Type: schema.TypeString, | ||
Computed: true, | ||
Optional: true, | ||
ConflictsWith: []string{"preferred_versions"}, | ||
}, | ||
|
||
"version_description": { | ||
Type: schema.TypeString, | ||
Computed: true, | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
func dataSourceAwsRdsEngineVersionRead(d *schema.ResourceData, meta interface{}) error { | ||
conn := meta.(*AWSClient).rdsconn | ||
|
||
input := &rds.DescribeDBEngineVersionsInput{ | ||
ListSupportedCharacterSets: aws.Bool(true), | ||
ListSupportedTimezones: aws.Bool(true), | ||
} | ||
|
||
if v, ok := d.GetOk("engine"); ok { | ||
input.Engine = aws.String(v.(string)) | ||
} | ||
|
||
if v, ok := d.GetOk("parameter_group_name"); ok { | ||
input.DBParameterGroupFamily = aws.String(v.(string)) | ||
} | ||
|
||
if v, ok := d.GetOk("version"); ok { | ||
input.EngineVersion = aws.String(v.(string)) | ||
} | ||
|
||
if _, ok := d.GetOk("version"); !ok { | ||
if _, ok := d.GetOk("preferred_versions"); !ok { | ||
input.DefaultOnly = aws.Bool(true) | ||
} | ||
} | ||
|
||
log.Printf("[DEBUG] Reading RDS engine versions: %v", input) | ||
var engineVersions []*rds.DBEngineVersion | ||
|
||
err := conn.DescribeDBEngineVersionsPages(input, func(resp *rds.DescribeDBEngineVersionsOutput, lastPage bool) bool { | ||
for _, engineVersion := range resp.DBEngineVersions { | ||
if engineVersion == nil { | ||
continue | ||
} | ||
|
||
engineVersions = append(engineVersions, engineVersion) | ||
} | ||
return !lastPage | ||
}) | ||
|
||
if err != nil { | ||
return fmt.Errorf("error reading RDS engine versions: %w", err) | ||
} | ||
|
||
if len(engineVersions) == 0 { | ||
return fmt.Errorf("no RDS engine versions found") | ||
} | ||
|
||
// preferred versions | ||
var found *rds.DBEngineVersion | ||
if l := d.Get("preferred_versions").([]interface{}); len(l) > 0 { | ||
for _, elem := range l { | ||
preferredVersion, ok := elem.(string) | ||
|
||
if !ok { | ||
continue | ||
} | ||
|
||
for _, engineVersion := range engineVersions { | ||
if preferredVersion == aws.StringValue(engineVersion.EngineVersion) { | ||
found = engineVersion | ||
break | ||
} | ||
} | ||
|
||
if found != nil { | ||
break | ||
} | ||
} | ||
} | ||
|
||
if found == nil && len(engineVersions) > 1 { | ||
return fmt.Errorf("multiple RDS engine versions (%v) match the criteria", engineVersions) | ||
} | ||
|
||
if found == nil && len(engineVersions) == 1 { | ||
found = engineVersions[0] | ||
} | ||
|
||
if found == nil { | ||
return fmt.Errorf("no RDS engine versions match the criteria") | ||
} | ||
|
||
d.SetId(aws.StringValue(found.EngineVersion)) | ||
|
||
if found.DefaultCharacterSet != nil { | ||
d.Set("default_character_set", found.DefaultCharacterSet.CharacterSetName) | ||
} | ||
|
||
d.Set("engine", found.Engine) | ||
d.Set("engine_description", found.DBEngineDescription) | ||
d.Set("exportable_log_types", found.ExportableLogTypes) | ||
d.Set("parameter_group_name", found.DBParameterGroupFamily) | ||
d.Set("status", found.Status) | ||
|
||
var characterSets []string | ||
for _, cs := range found.SupportedCharacterSets { | ||
characterSets = append(characterSets, aws.StringValue(cs.CharacterSetName)) | ||
} | ||
d.Set("supported_character_sets", characterSets) | ||
|
||
d.Set("supported_feature_names", found.SupportedFeatureNames) | ||
d.Set("supported_modes", found.SupportedEngineModes) | ||
|
||
var timezones []string | ||
for _, tz := range found.SupportedTimezones { | ||
timezones = append(timezones, aws.StringValue(tz.TimezoneName)) | ||
} | ||
d.Set("supported_timezones", timezones) | ||
|
||
d.Set("supports_global_databases", found.SupportsGlobalDatabases) | ||
d.Set("supports_log_exports_to_cloudwatch", found.SupportsLogExportsToCloudwatchLogs) | ||
d.Set("supports_parallel_query", found.SupportsParallelQuery) | ||
d.Set("supports_read_replica", found.SupportsReadReplica) | ||
|
||
var upgradeTargets []string | ||
for _, ut := range found.ValidUpgradeTarget { | ||
upgradeTargets = append(upgradeTargets, aws.StringValue(ut.EngineVersion)) | ||
} | ||
d.Set("valid_upgrade_targets", upgradeTargets) | ||
|
||
d.Set("version", found.EngineVersion) | ||
d.Set("version_description", found.DBEngineVersionDescription) | ||
|
||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
package aws | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
"github.com/aws/aws-sdk-go/aws" | ||
"github.com/aws/aws-sdk-go/service/rds" | ||
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource" | ||
) | ||
|
||
func TestAccAWSRDSEngineVersionDataSource_basic(t *testing.T) { | ||
dataSourceName := "data.aws_rds_engine_version.test" | ||
engine := "mysql" | ||
version := "5.7.17" | ||
paramGroup := "mysql5.7" | ||
|
||
resource.ParallelTest(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t); testAccPreCheckAWSRDSEngineVersion(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: nil, | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testAccAWSRDSEngineVersionDataSourceBasicConfig(engine, version, paramGroup), | ||
Check: resource.ComposeTestCheckFunc( | ||
resource.TestCheckResourceAttr(dataSourceName, "engine", engine), | ||
resource.TestCheckResourceAttr(dataSourceName, "version", version), | ||
resource.TestCheckResourceAttr(dataSourceName, "parameter_group_name", paramGroup), | ||
), | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func TestAccAWSRDSEngineVersionDataSource_preferred(t *testing.T) { | ||
dataSourceName := "data.aws_rds_engine_version.test" | ||
|
||
resource.ParallelTest(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t); testAccPreCheckAWSRDSEngineVersion(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: nil, | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testAccAWSRDSEngineVersionDataSourcePreferredConfig(), | ||
Check: resource.ComposeTestCheckFunc( | ||
resource.TestCheckResourceAttr(dataSourceName, "version", "5.7.19"), | ||
), | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func TestAccAWSRDSEngineVersionDataSource_defaultOnly(t *testing.T) { | ||
dataSourceName := "data.aws_rds_engine_version.test" | ||
|
||
resource.ParallelTest(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t); testAccPreCheckAWSRDSEngineVersion(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: nil, | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testAccAWSRDSEngineVersionDataSourceDefaultOnlyConfig(), | ||
Check: resource.ComposeTestCheckFunc( | ||
resource.TestCheckResourceAttrSet(dataSourceName, "version"), | ||
), | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func testAccPreCheckAWSRDSEngineVersion(t *testing.T) { | ||
conn := testAccProvider.Meta().(*AWSClient).rdsconn | ||
|
||
input := &rds.DescribeDBEngineVersionsInput{ | ||
Engine: aws.String("mysql"), | ||
DefaultOnly: aws.Bool(true), | ||
} | ||
|
||
_, err := conn.DescribeDBEngineVersions(input) | ||
|
||
if testAccPreCheckSkipError(err) { | ||
t.Skipf("skipping acceptance testing: %s", err) | ||
} | ||
|
||
if err != nil { | ||
t.Fatalf("unexpected PreCheck error: %s", err) | ||
} | ||
} | ||
|
||
func testAccAWSRDSEngineVersionDataSourceBasicConfig(engine, version, paramGroup string) string { | ||
return fmt.Sprintf(` | ||
data "aws_rds_engine_version" "test" { | ||
engine = %q | ||
version = %q | ||
parameter_group_name = %q | ||
} | ||
`, engine, version, paramGroup) | ||
} | ||
|
||
func testAccAWSRDSEngineVersionDataSourcePreferredConfig() string { | ||
return fmt.Sprintf(` | ||
data "aws_rds_engine_version" "test" { | ||
engine = "mysql" | ||
preferred_versions = ["85.9.12", "5.7.19", "5.7.17"] | ||
} | ||
`) | ||
} | ||
|
||
func testAccAWSRDSEngineVersionDataSourceDefaultOnlyConfig() string { | ||
return fmt.Sprintf(` | ||
data "aws_rds_engine_version" "test" { | ||
engine = "mysql" | ||
} | ||
`) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.