-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tests/resource/aws_api_gateway_domain_name: Remove hardcoded environm…
…ent variable handling, create public ACM certificate, improve state value checks Reference: #8316 Reference: #14664 Reference: #15737 Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSAPIGatewayDomainName_disappears (20.54s) --- PASS: TestAccAWSAPIGatewayDomainName_RegionalCertificateArn (81.84s) --- PASS: TestAccAWSAPIGatewayDomainName_SecurityPolicy (139.42s) --- PASS: TestAccAWSAPIGatewayDomainName_Tags (203.73s) --- SKIP: TestAccAWSAPIGatewayDomainName_CertificateName (0.00s) --- SKIP: TestAccAWSAPIGatewayDomainName_RegionalCertificateName (0.00s) ``` Output from acceptance testing in AWS GovCloud (US) (other tests failing with ACM quota limits): ``` --- SKIP: TestAccAWSAPIGatewayDomainName_CertificateArn (1.58s) ```
- Loading branch information
Showing
3 changed files
with
190 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| package aws | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "sync" | ||
| "testing" | ||
|
|
||
| "github.com/aws/aws-sdk-go/aws/arn" | ||
| "github.com/aws/aws-sdk-go/aws/endpoints" | ||
| "github.com/aws/aws-sdk-go/service/apigateway" | ||
| "github.com/hashicorp/terraform-plugin-sdk/v2/diag" | ||
| "github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource" | ||
| "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema" | ||
| "github.com/hashicorp/terraform-plugin-sdk/v2/terraform" | ||
| ) | ||
|
|
||
| // API Gateway Edge-Optimized Domain Name can only be created with ACM Certificates in specific regions. | ||
|
|
||
| // testAccApigatewayEdgeDomainNameRegion is the chosen API Gateway Domain Name testing region | ||
| // | ||
| // Cached to prevent issues should multiple regions become available. | ||
| var testAccApigatewayEdgeDomainNameRegion string | ||
|
|
||
| // testAccProviderApigatewayEdgeDomainName is the API Gateway Domain Name provider instance | ||
| // | ||
| // This Provider can be used in testing code for API calls without requiring | ||
| // the use of saving and referencing specific ProviderFactories instances. | ||
| // | ||
| // testAccPreCheckApigatewayEdgeDomainName(t) must be called before using this provider instance. | ||
| var testAccProviderApigatewayEdgeDomainName *schema.Provider | ||
|
|
||
| // testAccProviderApigatewayEdgeDomainNameConfigure ensures the provider is only configured once | ||
| var testAccProviderApigatewayEdgeDomainNameConfigure sync.Once | ||
|
|
||
| // testAccPreCheckApigatewayEdgeDomainName verifies AWS credentials and that API Gateway Domain Name is supported | ||
| func testAccPreCheckApigatewayEdgeDomainName(t *testing.T) { | ||
| testAccPartitionHasServicePreCheck(apigateway.EndpointsID, t) | ||
|
|
||
| // Since we are outside the scope of the Terraform configuration we must | ||
| // call Configure() to properly initialize the provider configuration. | ||
| testAccProviderApigatewayEdgeDomainNameConfigure.Do(func() { | ||
| testAccProviderApigatewayEdgeDomainName = Provider() | ||
|
|
||
| region := testAccGetApigatewayEdgeDomainNameRegion() | ||
|
|
||
| if region == "" { | ||
| t.Skip("API Gateway Domain Name not available in this AWS Partition") | ||
| } | ||
|
|
||
| config := map[string]interface{}{ | ||
| "region": region, | ||
| } | ||
|
|
||
| diags := testAccProviderApigatewayEdgeDomainName.Configure(context.Background(), terraform.NewResourceConfigRaw(config)) | ||
|
|
||
| if diags != nil && diags.HasError() { | ||
| for _, d := range diags { | ||
| if d.Severity == diag.Error { | ||
| t.Fatalf("error configuring API Gateway Domain Name provider: %s", d.Summary) | ||
| } | ||
| } | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| // testAccApigatewayEdgeDomainNameRegionProviderConfig is the Terraform provider configuration for API Gateway Domain Name region testing | ||
| // | ||
| // Testing API Gateway Domain Name assumes no other provider configurations | ||
| // are necessary and overwrites the "aws" provider configuration. | ||
| func testAccApigatewayEdgeDomainNameRegionProviderConfig() string { | ||
| return testAccRegionalProviderConfig(testAccGetApigatewayEdgeDomainNameRegion()) | ||
| } | ||
|
|
||
| // testAccGetApigatewayEdgeDomainNameRegion returns the API Gateway Domain Name region for testing | ||
| func testAccGetApigatewayEdgeDomainNameRegion() string { | ||
| if testAccApigatewayEdgeDomainNameRegion != "" { | ||
| return testAccApigatewayEdgeDomainNameRegion | ||
| } | ||
|
|
||
| // AWS Commercial: https://docs.aws.amazon.com/apigateway/latest/developerguide/how-to-custom-domains.html | ||
| // AWS GovCloud (US) - edge custom domain names not supported: https://docs.aws.amazon.com/govcloud-us/latest/UserGuide/govcloud-abp.html | ||
| // AWS China - edge custom domain names not supported: https://docs.amazonaws.cn/en_us/aws/latest/userguide/api-gateway.html | ||
| switch testAccGetPartition() { | ||
| case endpoints.AwsPartitionID: | ||
| testAccApigatewayEdgeDomainNameRegion = endpoints.UsEast1RegionID | ||
| } | ||
|
|
||
| return testAccApigatewayEdgeDomainNameRegion | ||
| } | ||
|
|
||
| // testAccCheckResourceAttrRegionalARNApigatewayEdgeDomainName ensures the Terraform state exactly matches the expected API Gateway Edge Domain Name format | ||
| func testAccCheckResourceAttrRegionalARNApigatewayEdgeDomainName(resourceName, attributeName, arnService string, domain string) resource.TestCheckFunc { | ||
| return func(s *terraform.State) error { | ||
| attributeValue := arn.ARN{ | ||
| Partition: testAccGetPartition(), | ||
| Region: testAccGetApigatewayEdgeDomainNameRegion(), | ||
| Resource: fmt.Sprintf("/domainnames/%s", domain), | ||
| Service: arnService, | ||
| }.String() | ||
|
|
||
| return resource.TestCheckResourceAttr(resourceName, attributeName, attributeValue)(s) | ||
| } | ||
| } | ||
|
|
||
| // testAccCheckResourceAttrRegionalARNApigatewayRegionalDomainName ensures the Terraform state exactly matches the expected API Gateway Regional Domain Name format | ||
| func testAccCheckResourceAttrRegionalARNApigatewayRegionalDomainName(resourceName, attributeName, arnService string, domain string) resource.TestCheckFunc { | ||
| return func(s *terraform.State) error { | ||
| attributeValue := arn.ARN{ | ||
| Partition: testAccGetPartition(), | ||
| Region: testAccGetRegion(), | ||
| Resource: fmt.Sprintf("/domainnames/%s", domain), | ||
| Service: arnService, | ||
| }.String() | ||
|
|
||
| return resource.TestCheckResourceAttr(resourceName, attributeName, attributeValue)(s) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters