Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS App Mesh support for TLS in transit encryption #10922

Closed
brunocous opened this issue Nov 19, 2019 · 6 comments · Fixed by #12541
Closed

AWS App Mesh support for TLS in transit encryption #10922

brunocous opened this issue Nov 19, 2019 · 6 comments · Fixed by #12541
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Milestone

Comments

@brunocous
Copy link

brunocous commented Nov 19, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Encryption in transit is an important feature for service meshes. App Mesh support's for it is still for preview channel only (see ref 1). The virtual node Terraform resource does not provide the option at the moment.

New or Affected Resource(s)

Proposed interface

According to the documentation, a certificate should be created somewhere (ACM), and a tls object should be added to the listener of each virtual node. This tls object has two options: a mode and reference to a ACM certificate.

"tls": {
            "mode": "STRICT",
            "certificate": {
                "acm": {
                    "certificateArn": "${CERTIFICATE_ARN}"
                }
            }
        }

References

@brunocous brunocous added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 19, 2019
@ghost ghost added the service/appmesh Issues and PRs that pertain to the appmesh service. label Nov 19, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 19, 2019
@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 19, 2019

@brunocous I had been looking at the App Mesh preview channel in #9468 but put this on pause as the features started to move into the release channel.
I'm not sure what plans are for supporting preview channels in general.
See also #11850,

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Nov 19, 2019
@SeanFaheyYgrene
Copy link

@ewbankkit as a heads up this feature is now out of preview.

@SebastianC
Copy link
Contributor

any idea when this may be reviewed/merged?

@ewbankkit ewbankkit self-assigned this Jul 26, 2020
@lays147
Copy link

lays147 commented Sep 18, 2020

Is there any timeline when this will be available on the provider?

@breathingdust breathingdust added this to the v3.9.0 milestone Sep 30, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
7 participants