Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve aws_launch_template documentation to mention describe delete_on_termination behavior #12983

Closed
breathingdust opened this issue Apr 23, 2020 · 2 comments · Fixed by #13546
Closed

Improve aws_launch_template documentation to mention describe delete_on_termination behavior #12983

breathingdust opened this issue Apr 23, 2020 · 2 comments · Fixed by #13546
Assignees
@anGie44
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.

Comments

@breathingdust
Copy link
Member

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Improve the documentation of aws_launch_template to describe the behavior mentioned in #8612. This can cause unexpected issues for practitioners. The actual fix for the issue involves a breaking change and therefore must wait for resolution in the next major release.

New or Affected Resource(s)

  • aws_launch_template

References
@breathingdust breathingdust added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 23, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Apr 23, 2020
@breathingdust breathingdust added the documentation Introduces or discusses updates to documentation. label Apr 23, 2020
@anGie44 anGie44 mentioned this issue May 28, 2020
Merged
@phils
Copy link
Contributor

phils commented Jun 20, 2020

@anGie44 Thanks.. is there a ticket in the 3.0 milestone to make this breaking change?

@ghost
Copy link

ghost commented Jul 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anGie44 anGie44

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
No milestone
3 participants
@phils @breathingdust @anGie44