Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on lambda updates, output the returned values to ensure consistency #14578

Merged
merged 4 commits into from
Feb 18, 2021

Conversation

keithcom
Copy link

@keithcom keithcom commented Aug 11, 2020

On lambda updates that publish new versions, output the returned values to ensure consistency as the read is eventually consistent.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14210
Closes #13099

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLambdaFunction_versioned'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_versioned -timeout 120m
=== RUN   TestAccAWSLambdaFunction_versioned
=== PAUSE TestAccAWSLambdaFunction_versioned
=== RUN   TestAccAWSLambdaFunction_versionedUpdate
=== PAUSE TestAccAWSLambdaFunction_versionedUpdate
=== CONT  TestAccAWSLambdaFunction_versioned
=== CONT  TestAccAWSLambdaFunction_versionedUpdate
--- PASS: TestAccAWSLambdaFunction_versioned (37.82s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (64.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	65.540s

@keithcom keithcom requested a review from a team August 11, 2020 20:20
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. needs-triage Waiting for first response or review from a maintainer. labels Aug 11, 2020
@kevinmstephens
Copy link

This fixes #13099 too!

@kevinmstephens
Copy link

is there any timeline for this getting merged? auto lambda versioning is broken without this

@danieladams456
Copy link
Contributor

This would be a helpful fix!

Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@YakDriver YakDriver self-assigned this Feb 18, 2021
@YakDriver
Copy link
Member

@keithcom Thank you for your work on this PR! I will be working on this before long. In order to expedite the process, I will likely make some changes. Make sure that you have checked the box "Allow edits from maintainers." (Don't worry though, you will receive all credit for your contribution and code!) Also, please coordinate with us before making any commits to this branch. Again, thank you for your help and we look forward to this popular addition to the AWS provider!

@YakDriver YakDriver force-pushed the b-output-correct-lambda-version branch from fee7899 to b64f075 Compare February 18, 2021 20:22
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Feb 18, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

GovCloud:

--- PASS: TestAccAWSLambdaFunction_versioned (45.55s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (76.22s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (77.48s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (96.20s)
--- PASS: TestAccAWSLambdaAlias_basic (43.96s)
--- PASS: TestAccAWSLambdaAlias_FunctionName_Name (54.76s)
--- PASS: TestAccAWSLambdaAlias_nameupdate (62.34s)
--- PASS: TestAccAWSLambdaAlias_routingconfig (70.64s)

us-west-2:

--- PASS: TestAccAWSLambdaFunction_versioned (50.41s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (80.97s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (89.92s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (90.78s)
--- PASS: TestAccAWSLambdaAlias_nameupdate (40.70s)
--- PASS: TestAccAWSLambdaAlias_FunctionName_Name (43.94s)
--- PASS: TestAccAWSLambdaAlias_basic (44.22s)
--- PASS: TestAccAWSLambdaAlias_routingconfig (74.77s)

@YakDriver YakDriver added this to the v3.29.0 milestone Feb 18, 2021
@YakDriver YakDriver merged commit 78f9765 into hashicorp:main Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
8 participants