Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ebs_volume: support io2 volume type #14817

Closed
roberth-k opened this issue Aug 25, 2020 · 14 comments · Fixed by #14894 or #14906
Closed

resource/aws_ebs_volume: support io2 volume type #14817

roberth-k opened this issue Aug 25, 2020 · 14 comments · Fixed by #14894 or #14906
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@roberth-k
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS have introduced the io2 volume type. On create, the aws_ebs_volume resource currently rejects the iops attribute for volumes that are not io1.

Requires Go SDK 1.34.10.

New or Affected Resource(s)

  • aws_ebs_volume

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

@roberth-k roberth-k added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 25, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Aug 25, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 25, 2020
@ewbankkit
Copy link
Contributor

There should also be support across other resources where a volume type can be specified:

  • aws_ami
  • aws_instance
  • aws_launch_configuration
  • aws_launch_template
  • aws_spot_fleet_request

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 25, 2020
@chriswahl
Copy link

In case folks are searching the web with the error code, this is what is returned via CLI:

Error: Error creating EC2 volume: InvalidParameterCombination: The parameter iops must be specified for io2 volumes.
        status code: 400, request id: aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee

@bflad
Copy link
Contributor

bflad commented Aug 28, 2020

Going to re-open this until its supported across the other resources as mentioned above.

@bflad bflad reopened this Aug 28, 2020
@bflad bflad added this to the v3.5.0 milestone Sep 2, 2020
@bflad
Copy link
Contributor

bflad commented Sep 2, 2020

Support for the other EC2 resources has been merged and will release with version 3.5.0 of the Terraform AWS Provider, likely tomorrow. Thanks to @nikhil-goenka for the implementation. 👍

@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@julian3xl
Copy link
Contributor

Error: Error creating launch configuration: ValidationError: io2 is invalid. Valid volume types are standard, io1, gp2, st1 and sc1. status code: 400, request id: 6f40d1e2-1cbc-4e9e-bf4c-8d5c4687d1f1

  • provider.aws: version = "~> 3.7"
  • provider.external: version = "~> 1.2"
  • provider.helm: version = "~> 1.3"
  • provider.kubernetes: version = "~> 1.13"
  • provider.null: version = "~> 2.1"
  • provider.template: version = "~> 2.1"

@julian3xl
Copy link
Contributor

so, what's the problem if its supposed this was released in 3.5?

@bflad
Copy link
Contributor

bflad commented Sep 23, 2020

Hi @julian3xl 👋 That error is being returned by the Auto Scaling API. You may want to verify that you are in an AWS Region that supports the new io2 Volume type:

EBS io2 volumes are generally available in US East (Ohio), US East (N. Virginia), US West (N. California), US West (Oregon), Asia Pacific (Hong Kong), Asia Pacific (Mumbai), Asia Pacific (Seoul), Asia Pacific (Singapore), Asia Pacific (Sydney), Asia Pacific (Tokyo), Canada (Central), Europe (Frankfurt), Europe (Ireland), Europe (London), Europe (Stockholm), and Middle East (Bahrain) with more regions coming soon.

Or otherwise open an AWS Support case.

@julian3xl
Copy link
Contributor

Cool! thanks @bflad, I'll request for support because I'm running at Ireland so initially it's supposed it should be available there.

@julian3xl
Copy link
Contributor

Anyway, documentation https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_configuration#volume_type still doesn't say anything about io2 🤷‍♂️

@bflad
Copy link
Contributor

bflad commented Sep 23, 2020

Looks like the Auto Scaling API Reference for EBS volume handling does not list io2 yet as a valid value. The AWS service team will know best whether this support was intentionally not added (more movement towards encouraging usage of EC2 Launch Templates instead) or if this will be part of future Auto Scaling API releases.

@roberth-k
Copy link
Contributor Author

AWS have deprecated Launch Configurations, so it's not surprising that it would lag in features. It's worth considering migrating to Launch Templates for immediate io2 support.

@julian3xl
Copy link
Contributor

Hi guys, thanks both of you, finally I moved to launch templates and it worked.

@ghost
Copy link

ghost commented Oct 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
5 participants