Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_xray_sampling_rule: Implement resource tagging support #14823

Closed
bflad opened this issue Aug 25, 2020 · 3 comments · Fixed by #14831
Closed

resource/aws_xray_sampling_rule: Implement resource tagging support #14823

bflad opened this issue Aug 25, 2020 · 3 comments · Fixed by #14831
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/xray Issues and PRs that pertain to the xray service.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Aug 25, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The X-Ray API has now added resource tagging capabilities, which can be implemented in the aws_xray_sampling_rule resource. This support includes tag-on-create with existing creation API calls, such as CreateSamplingRule.

Affected Resource(s)

  • aws_xray_sampling_rule

Potential Terraform Configuration

resource "aws_xray_sampling_rule" "example" {
  # ... other configuration ...

  tags = {
    Key1 = "Value1"
  }
}

References

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/xray Issues and PRs that pertain to the xray service. labels Aug 25, 2020
@DrFaust92 DrFaust92 self-assigned this Aug 25, 2020
@bflad bflad added this to the v3.4.0 milestone Aug 25, 2020
@bflad
Copy link
Contributor Author

bflad commented Aug 25, 2020

Support for resource tagging with the aws_xray_sampling_rule resource has been merged and will release with version 3.4.0 of the Terraform AWS Provider, later this week. Thanks to @DrFaust92 for the implementation. 👍

@ghost
Copy link

ghost commented Aug 27, 2020

This has been released in version 3.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 24, 2020
@DrFaust92 DrFaust92 removed their assignment Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/xray Issues and PRs that pertain to the xray service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants