Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ClientVpnAuthorizationRuleActiveTimeout and ClientVpnAuthoriz… #15037

Conversation

connor-tyndall
Copy link
Contributor

Updated ClientVpnAuthorizationRuleActiveTimeout and ClientVpnAuthorizationRuleRevokedTimeout to 5 minute timeout

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #14156

Release note for CHANGELOG:

resource/aws_ec2_client_vpn_authorization_rule: Update timeout from 1min to 5min

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2ClientVpnAuthorizationRules_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2ClientVpnAuthorizationRules_ -timeout 120m
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       4.167s [no tests to run]

...

@connor-tyndall connor-tyndall requested a review from a team September 4, 2020 21:11
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Sep 4, 2020
@ChristophShyper
Copy link
Contributor

Can someone have a look at it? aws_ec2_client_vpn_authorization_rule is literally unusable without this change.

@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2020
@bflad bflad self-assigned this Sep 8, 2020
@bflad bflad added this to the v3.6.0 milestone Sep 8, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this fix, @connor-tyndall 🚀

Output from acceptance testing:

    --- PASS: TestAccAwsEc2ClientVpn_serial/AuthorizationRule_basic (37.06s)
    --- PASS: TestAccAwsEc2ClientVpn_serial/AuthorizationRule_disappears (42.28s)
    --- PASS: TestAccAwsEc2ClientVpn_serial/AuthorizationRule_groups (75.49s)
    --- PASS: TestAccAwsEc2ClientVpn_serial/AuthorizationRule_Subnets (58.36s)

@bflad bflad merged commit a21578e into hashicorp:master Sep 8, 2020
bflad added a commit that referenced this pull request Sep 8, 2020
@ghost
Copy link

ghost commented Sep 11, 2020

This has been released in version 3.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@analytically
Copy link

Even 5 minutes fails for me in ap-northeast-1. 10 minutes seems more realistic.

@Fuuzetsu
Copy link

I made #15349 for further increasing timeout. I'm also in ap-northeast-1 and seeing this.

@ghost
Copy link

ghost commented Oct 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ec2_client_vpn_authorization_rule timeout after 1m0s
5 participants