Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsx_lustre_file_system - support daily_automatic_backup_start_time #15299

Merged
merged 5 commits into from
Oct 1, 2020
Merged

fsx_lustre_file_system - support daily_automatic_backup_start_time #15299

merged 5 commits into from
Oct 1, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Sep 23, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14930

Release note for CHANGELOG:

resource_aws_fsx_lustre_file_system - support `daily_automatic_backup_start_time`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime (714.26s)
--- PASS: TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays (783.06s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 (478.52s)

@DrFaust92 DrFaust92 requested a review from a team September 23, 2020 11:45
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Sep 23, 2020
@DrFaust92 DrFaust92 marked this pull request as draft September 23, 2020 12:16
@DrFaust92 DrFaust92 marked this pull request as ready for review September 23, 2020 14:36
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 23, 2020
ewbankkit
ewbankkit approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccAWSFsxLustreFileSystem_basic (531.94s)
--- PASS: TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime (566.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	566.485s

@DrFaust92 DrFaust92 force-pushed the fsx_lustre_file_system_daily_auto_maint branch from 546439a to 7e5d550 Compare September 30, 2020 23:18
@DrFaust92 DrFaust92 mentioned this pull request Sep 30, 2020
Merged
@breathingdust
Copy link
Member

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime (494.40s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (593.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	594.988s

@breathingdust breathingdust added this to the v3.9.0 milestone Oct 1, 2020
@breathingdust breathingdust merged commit 704d0cc into hashicorp:master Oct 1, 2020
breathingdust added a commit that referenced this pull request Oct 1, 2020
@breathingdust
Update CHANGELOG for #15299
34e0df3
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2020
@DrFaust92 DrFaust92 deleted the fsx_lustre_file_system_daily_auto_maint branch April 15, 2021 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

Support backups in aws_fsx_lustre_file_system
3 participants
@DrFaust92 @breathingdust @ewbankkit