resource/aws_lb: Fix enable_cross_zone_load_balancing argument handling with Gateway Load Balancers #16314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng with Gateway Load Balancers Reference: #16311 Previously: ``` === CONT TestAccAWSLB_LoadBalancerType_Gateway_EnableCrossZoneLoadBalancing resource_aws_lb_test.go:202: Step 1/3 error: Check failed: 1 error occurred: * Check 4/4 error: aws_lb.test: Attribute 'enable_cross_zone_load_balancing' expected "true", got "false" --- FAIL: TestAccAWSLB_LoadBalancerType_Gateway_EnableCrossZoneLoadBalancing (108.37s) ``` Output from acceptance testing: ``` --- PASS: TestAccAWSLB_ALB_AccessLogs (353.95s) --- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (304.17s) --- PASS: TestAccAWSLB_ALB_basic (179.02s) --- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (280.99s) --- PASS: TestAccAWSLB_applicationLoadBalancer_updateDropInvalidHeaderFields (291.94s) --- PASS: TestAccAWSLB_applicationLoadBalancer_updateHttp2 (336.62s) --- PASS: TestAccAWSLB_BackwardsCompatibility (227.48s) --- PASS: TestAccAWSLB_generatedName (218.44s) --- PASS: TestAccAWSLB_generatesNameForZeroValue (168.08s) --- PASS: TestAccAWSLB_LoadBalancerType_Gateway (106.07s) --- PASS: TestAccAWSLB_LoadBalancerType_Gateway_EnableCrossZoneLoadBalancing (156.75s) --- PASS: TestAccAWSLB_namePrefix (163.49s) --- PASS: TestAccAWSLB_networkLoadbalancer_subnet_change (234.08s) --- PASS: TestAccAWSLB_networkLoadbalancer_updateCrossZone (313.68s) --- PASS: TestAccAWSLB_networkLoadbalancerEIP (221.91s) --- PASS: TestAccAWSLB_NLB_AccessLogs (404.54s) --- PASS: TestAccAWSLB_NLB_AccessLogs_Prefix (359.52s) --- PASS: TestAccAWSLB_NLB_basic (216.80s) --- PASS: TestAccAWSLB_NLB_privateipv4address (228.17s) --- PASS: TestAccAWSLB_noSecurityGroup (166.60s) --- PASS: TestAccAWSLB_tags (328.23s) --- PASS: TestAccAWSLB_updatedIpAddressType (241.45s) --- PASS: TestAccAWSLB_updatedSecurityGroups (236.45s) --- PASS: TestAccAWSLB_updatedSubnets (279.80s) --- SKIP: TestAccAWSLB_ALB_outpost (2.65s) ```
ghost
added
size/M
|
Ut-oh. I'm getting failures on 0.12.29 and 0.13.5 on GovCloud. |
|
And, on 0.13.5 on commercial, it works fine: |
YakDriver
requested changes
Nov 19, 2020
There was a problem hiding this comment.
If crozz zone is not possible on GovCloud, the test should skip. Not sure that's the izzue. In any case, consistently getting GovCloud failz:
--- FAIL: TestAccAWSLB_LoadBalancerType_Gateway (17.52s)
--- FAIL: TestAccAWSLB_LoadBalancerType_Gateway_EnableCrossZoneLoadBalancing (17.86s)
|
This validation error is being returned by the API: Gateway Load Balancers are only supported in a few regions currently: https://aws.amazon.com/blogs/aws/introducing-aws-gateway-load-balancer-easy-deployment-scalability-and-high-availability-for-partner-appliances/
It is a little clumsy, but we could do a PreCheck against the $ aws --region us-west-2 elbv2 describe-account-limits | jq '.Limits[] | select(.Name == "gateway-load-balancers")'
{
"Name": "gateway-load-balancers",
"Max": "20"
}
$ aws --region us-east-2 elbv2 describe-account-limits | jq '.Limits[] | select(.Name == "gateway-load-balancers")'
$ $ aws --region us-gov-west-1 elbv2 describe-account-limits | jq '.Limits[] | select(.Name == "gateway-load-balancers")'
$ |
Reference: #16314 (comment) Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSLB_LoadBalancerType_Gateway (109.15s) --- PASS: TestAccAWSLB_LoadBalancerType_Gateway_EnableCrossZoneLoadBalancing (159.02s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- SKIP: TestAccAWSLB_LoadBalancerType_Gateway (1.70s) --- SKIP: TestAccAWSLB_LoadBalancerType_Gateway_EnableCrossZoneLoadBalancing (1.70s) ```
|
Added. Output from acceptance testing in AWS Commercial: Output from acceptance testing in AWS GovCloud (US): For followup, this new PreCheck will need to be added to a few other tests: |
5 tasks
|
I added #16322 for follow-up on those tests. |
YakDriver
approved these changes
Nov 19, 2020
|
This has been released in version 3.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #16311
Release note for CHANGELOG:
Previously:
Output from acceptance testing: