Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data_source_aws_elb_hosted_zone_id #17226

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Update data_source_aws_elb_hosted_zone_id #17226

merged 1 commit into from
Jan 26, 2021

Conversation

shell-autonomic-sh
Copy link
Contributor

To fix this bug.
aws_elb_hosted_zone_id are wrong to the China region
#17225

@shell-autonomic-sh shell-autonomic-sh requested a review from a team as a code owner January 21, 2021 22:01
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/elb Issues and PRs that pertain to the elb service. labels Jan 21, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 21, 2021
github-actions[bot]
github-actions bot reviewed Jan 21, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @shell-autonomic-sh 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 21, 2021
Base automatically changed from master to main January 23, 2021 01:00
bflad
bflad approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix, @shell-autonomic-sh 🚀

@bflad bflad linked an issue Jan 26, 2021 that may be closed by this pull request
aws_elb_hosted_zone_id are wrong to the China region #17225
Closed
@bflad bflad added this to the v3.26.0 milestone Jan 26, 2021
bflad added a commit that referenced this pull request Jan 26, 2021
@bflad
Update CHANGELOG for #17226
77fab4e
@bflad bflad merged commit db73e9f into hashicorp:main Jan 26, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 3.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/elb Issues and PRs that pertain to the elb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.26.0
Development

Successfully merging this pull request may close these issues.

aws_elb_hosted_zone_id are wrong to the China region
3 participants
@shell-autonomic-sh @bflad @ewbankkit