IPv6 subnet mapping for lb #17229
Merged
IPv6 subnet mapping for lb #17229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/M
github-actions
bot
added
the
needs-triage
Add support for IPv6 subnet mapping to the aws_lb resource. Resolves #17150
bill-rich
force-pushed
the
f_support_ipv6_lb_subnet_mapping
branch
from
2e4a143
to
9adaeee
Compare
bill-rich
removed
the
needs-triage
anGie44
suggested changes
Feb 3, 2021
There was a problem hiding this comment.
Look great overall @bill-rich ! Just a couple quick comments for review.
output of acceptance tests in commercial:
--- FAIL: TestAccAWSLB_IPv6SubnetMapping (41.16s) -- only in TC, see note above about adding dependency in test config
--- SKIP: TestAccDataSourceAWSLB_outpost (1.36s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_disappears_ELB (38.35s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_disappears (40.81s)
--- PASS: TestAccAWSLBCookieStickinessPolicy_basic (47.57s)
--- PASS: TestAccAWSLBListenerRule_redirect (175.37s)
--- PASS: TestAccDataSourceAWSLBListener_basic (181.22s)
--- PASS: TestAccDataSourceAWSLB_basic (183.23s)
--- PASS: TestAccDataSourceAWSLB_BackwardsCompatibility (186.26s)
--- PASS: TestAccDataSourceAWSLBListener_DefaultAction_Forward (191.47s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (5.95s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (195.73s)
--- PASS: TestAccAWSLBListenerRule_basic (197.33s)
--- PASS: TestAccAWSLBListenerRule_cognito (199.61s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (202.44s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (227.43s)
--- PASS: TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility (228.93s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (183.16s)
--- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (56.67s)
--- PASS: TestAccDataSourceAWSLBListener_https (236.75s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (237.10s)
--- PASS: TestAccAWSLBListenerRule_updateFixedResponse (240.94s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (202.92s)
--- PASS: TestAccAWSLBListenerRule_forwardWeighted (245.31s)
--- PASS: TestAccAWSLBListenerRule_oidc (215.58s)
--- PASS: TestAccAWSLBListenerRule_BackwardsCompatibility (254.71s)
--- PASS: TestAccAWSLBListenerRule_priority (325.92s)
--- PASS: TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer (110.45s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (172.77s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader (181.96s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (175.38s)
--- PASS: TestAccAWSLBListenerRule_conditionQueryString (176.51s)
--- PASS: TestAccAWSLBListenerRule_conditionSourceIp (177.78s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (187.24s)
--- PASS: TestAccAWSLBListenerRule_conditionMultiple (175.84s)
--- PASS: TestAccAWSLBListener_basic (164.62s)
--- PASS: TestAccAWSLBSSLNegotiationPolicy_basic (35.90s)
--- PASS: TestAccAWSLBSSLNegotiationPolicy_disappears (35.84s)
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (190.14s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (226.44s)
--- PASS: TestAccAWSLBListener_cognito (179.00s)
--- PASS: TestAccAWSLBListener_redirect (189.01s)
--- PASS: TestAccAWSLBListener_https (199.32s)
--- PASS: TestAccAWSLBListener_fixedResponse (182.63s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (210.00s)
--- PASS: TestAccAWSLBTargetGroup_basic (34.97s)
--- PASS: TestAccAWSLBListener_forwardWeighted (220.85s)
--- PASS: TestAccAWSLBTargetGroupAttachment_lambda (52.63s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (30.52s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (33.16s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (31.78s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Geneve (36.69s)
--- PASS: TestAccAWSLBTargetGroupAttachment_Port (96.04s)
--- PASS: TestAccAWSLBTargetGroupAttachment_disappears (100.71s)
--- PASS: TestAccAWSLBTargetGroupAttachment_BackwardsCompatibility (98.05s)
--- PASS: TestAccAWSLBTargetGroupAttachment_basic (109.32s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (40.34s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (42.84s)
--- PASS: TestAccAWSLBTargetGroupAttachment_ipAddress (105.64s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (47.48s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (79.12s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (81.87s)
--- PASS: TestAccAWSLBListener_oidc (194.07s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (82.67s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (181.44s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (189.55s)
--- PASS: TestLBCloudwatchSuffixFromARN (0.00s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (60.75s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (99.22s)
--- PASS: TestAccAWSLBListener_basicUdp (333.20s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (101.23s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (137.42s)
--- SKIP: TestAccAWSLB_ALB_outpost (1.46s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (101.96s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (58.14s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (101.80s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (79.97s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (107.45s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (106.15s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (66.67s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (355.61s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (89.58s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (77.33s)
--- PASS: TestAccAWSLBTargetGroup_tags (135.67s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (124.42s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (114.36s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (129.98s)
--- PASS: TestAccAWSLB_LoadBalancerType_Gateway (121.30s)
--- PASS: TestAccAWSLB_LoadBalancerType_Gateway_EnableCrossZoneLoadBalancing (151.25s)
--- PASS: TestAccAWSLB_ALB_basic (193.09s)
--- PASS: TestAccAWSLB_generatesNameForZeroValue (175.91s)
--- PASS: TestAccAWSLB_BackwardsCompatibility (183.95s)
--- PASS: TestAccAWSLB_generatedName (189.73s)
--- PASS: TestAccAWSLB_namePrefix (187.20s)
--- PASS: TestAccAWSLB_NLB_basic (230.71s)
--- PASS: TestAccAWSLB_noSecurityGroup (179.64s)
--- PASS: TestAccAWSLB_networkLoadbalancerEIP (236.22s)
--- PASS: TestAccAWSLB_updatedSecurityGroups (220.88s)
--- PASS: TestAccAWSLB_updatedIpAddressType (229.93s)
--- PASS: TestAccAWSLB_updatedSubnets (239.15s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateHttp2 (257.96s)
--- PASS: TestAccAWSLB_tags (273.31s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDropInvalidHeaderFields (262.68s)
--- PASS: TestAccAWSLB_applicationLoadBalancer_updateDeletionProtection (271.29s)
--- PASS: TestAccAWSLB_networkLoadbalancer_updateCrossZone (326.84s)
--- PASS: TestAccAWSLB_ALB_AccessLogs_Prefix (263.94s)
--- PASS: TestAccAWSLB_ALB_AccessLogs (306.70s)
--- PASS: TestAccAWSLB_NLB_privateipv4address (390.01s)
--- PASS: TestAccAWSLB_networkLoadbalancer_subnet_change (215.19s)
--- PASS: TestAccAWSLB_NLB_AccessLogs_Prefix (317.14s)
--- PASS: TestAccAWSLB_NLB_AccessLogs (360.37s)
anGie44
reviewed
Feb 3, 2021
aws/resource_aws_lb_test.go
Outdated
| resourceName := "aws_lb.test" | ||
|
|
||
| resource.ParallelTest(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t); testAccPreCheckElbv2GatewayLoadBalancer(t) }, |
There was a problem hiding this comment.
i think this last precheck can be safely removed since this tests a network LB but i'll double check 👍
There was a problem hiding this comment.
OK yep ran the tests in us-gov-west-1 in case and the tests pass w/o the gateway precheck
There was a problem hiding this comment.
@bill-rich just one last note to update this to
Suggested change
| PreCheck: func() { testAccPreCheck(t); testAccPreCheckElbv2GatewayLoadBalancer(t) }, | |
| PreCheck: func() { testAccPreCheck(t) }, |
since we can run these in alternate regions/gov cloud afict. unless you've experienced something different 😃
anGie44
approved these changes
Feb 4, 2021
|
This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for IPv6 subnet mapping to the aws_lb resource.
Community Note
Closes #17150
Release note for CHANGELOG:
Output from acceptance testing: