Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_subnet_ids data source updated to not require vpc_id #18060

Closed
FireballDWF opened this issue Mar 12, 2021 · 4 comments · Fixed by #18803
Closed

aws_subnet_ids data source updated to not require vpc_id #18060

FireballDWF opened this issue Mar 12, 2021 · 4 comments · Fixed by #18803
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@FireballDWF
Copy link

FireballDWF commented Mar 12, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

aws_subnet_ids data source modified so the vpc_id argument is not required. The DescribeSubnets API call does not require vpc_id to be specified. Use case is want to return all subnets (regardless of vpc_id) which match a filter condition, in this case OutpostArn=value. Then use those subnets arns in a policy to deny launching in any subnet which is not an located on an Outpost, thus implementing a preventative control to enforce data residency

New or Affected Resource(s)

  • aws_subnet_ids

References

@FireballDWF FireballDWF added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 12, 2021
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Mar 12, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 12, 2021
@ewbankkit
Copy link
Contributor

Not sure whether removing vpc_id would be a breaking change.
Maybe we can take the opportunity to introduce a new data source aws_subnets (which conforms to the preferred naming), without the vpc_id attribute, and deprecate aws_subnet_ids?

@FireballDWF
Copy link
Author

I would be fine with a new data source

@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 17, 2021
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 17, 2021
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants