r/aws_mq_configuration: add missing authentication_strategy

[agranig]

When creating an ActiveMQ instance with authentication_strategy=ldap,
then the corresponding configuration has to contain the same option
as well for the user to be able to include a cachedLDAPAuthorizationMap
element in the broker xml configuration. If the option is not provided
when creating the configuration, the default strategy "simple" is
assumed and AWS automatically removes the cachedLDAPAuthorizationMap
element.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSMqConfiguration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMqConfiguration -timeout 180m
=== RUN   TestAccAWSMqConfiguration_basic
=== PAUSE TestAccAWSMqConfiguration_basic
=== RUN   TestAccAWSMqConfiguration_withData
=== PAUSE TestAccAWSMqConfiguration_withData
=== RUN   TestAccAWSMqConfiguration_withLdapData
=== PAUSE TestAccAWSMqConfiguration_withLdapData
=== RUN   TestAccAWSMqConfiguration_updateTags
=== PAUSE TestAccAWSMqConfiguration_updateTags
=== CONT  TestAccAWSMqConfiguration_basic
=== CONT  TestAccAWSMqConfiguration_withData
=== CONT  TestAccAWSMqConfiguration_updateTags
=== CONT  TestAccAWSMqConfiguration_withLdapData
--- PASS: TestAccAWSMqConfiguration_withLdapData (33.69s)
--- PASS: TestAccAWSMqConfiguration_withData (36.95s)
--- PASS: TestAccAWSMqConfiguration_basic (59.69s)
--- PASS: TestAccAWSMqConfiguration_updateTags (79.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	85.756s

[github-actions]

Welcome @agranig 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[YakDriver]

@agranig Thank you for this PR! I will be looking at it in the near future. I may need to make some minor changes. Coordinate with me if you intend to push to this branch and make sure to pull any changes I've made. Please note that you will still receive all credit for the PR and your code. Thanks again for your interest!

[YakDriver]

Looks great! 🎉

Acceptance tests on GovCloud:

--- SKIP: TestAccAWSMqConfiguration_updateTags (1.19s)
--- SKIP: TestAccAWSMqConfiguration_basic (1.19s)
--- SKIP: TestAccAWSMqConfiguration_withLdapData (1.19s)
--- SKIP: TestAccAWSMqConfiguration_withData (1.19s)

Acceptance tests on commercial (us-west-2):

--- PASS: TestAccAWSMqConfiguration_withLdapData (14.15s)
--- PASS: TestAccAWSMqConfiguration_basic (23.53s)
--- PASS: TestAccAWSMqConfiguration_withData (23.54s)
--- PASS: TestAccAWSMqConfiguration_updateTags (31.98s)

[agranig]

Thank's a lot for reviewing and merging this change!

[ghost]

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!