Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_route thinks route_table_id is a modifyable resource - its not #1841

Closed
gtmtech opened this issue Oct 9, 2017 · 3 comments · Fixed by #4946
Closed

aws_route thinks route_table_id is a modifyable resource - its not #1841

gtmtech opened this issue Oct 9, 2017 · 3 comments · Fixed by #4946
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@gtmtech
Copy link

gtmtech commented Oct 9, 2017

Terraform 0.9.8

This is super important, as terraform basically leaves routes hanging around which completely screws with your networking setup.

  1. Set up an aws_route, with a route_table_id
  2. Terraform it.
  3. Now change the route to be a different route_table_id

A plan now makes this a modify step (~) - it should be a destroy and create step (-/+)

An apply will error saying it could not find the old routes, (its looking for them on the wrong wroute table), and will then remove them from the state file(!!!!) - the next plan/apply will just apply them on the new route table, leaving the old routes behind on the old route table... this will break your entire networking model and potentially the security of your networks.

Really hope its been fixed since terraform 0.9.8 but havent had the chance to test yet - screwing up your networking is a pretty horrible thing for terraform to do!

If you're wondering why the route table might change, its because it may well come from a data source, and you've decided to change the VPC peering from A=>B, to A=>C - which is a common thing to do in e.g. blue-green type deployments

@Ninir Ninir added the bug Addresses a defect in current functionality. label Oct 11, 2017
@radeksimko radeksimko added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jan 28, 2018
@bflad bflad added this to the v1.25.0 milestone Jun 22, 2018
@bflad
Copy link
Contributor

bflad commented Jun 22, 2018

The fix for this has been merged into master and will release with version 1.25.0 of the AWS provider, likely middle of next week.

@bflad
Copy link
Contributor

bflad commented Jun 27, 2018

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants